From: Greg KH <gregkh@linuxfoundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Yao Hongbo <yaohongbo@linux.alibaba.com>,
linux-kernel@vger.kernel.org,
alikernel-developer@linux.alibaba.com
Subject: Re: [PATCH] uio/uio_pci_generic: Introduce refcnt on open/release
Date: Fri, 1 Apr 2022 08:17:41 +0200 [thread overview]
Message-ID: <YkaZBWqcOSBO28HU@kroah.com> (raw)
In-Reply-To: <20220331162521-mutt-send-email-mst@kernel.org>
On Thu, Mar 31, 2022 at 04:29:23PM -0400, Michael S. Tsirkin wrote:
> On Thu, Mar 31, 2022 at 10:06:24AM +0800, Yao Hongbo wrote:
> > If two userspace programs both open the PCI UIO fd, when one
> > of the program exits uncleanly, the other will cause IO hang
> > due to bus-mastering disabled.
>
> With two programs poking at the same device, how is this ever
> supposed to work even while both are alive?
>
> > It's a common usage for spdk/dpdk to use UIO.
>
> Except people really should just use vfio ...
Yes they should, the kernel should not care if multiple programs open
the same UIO device node, it can not prevent that and userspace is on
it's own here as it _should_ know what it is doing.
thanks,
greg k-h
prev parent reply other threads:[~2022-04-01 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 2:06 [PATCH] uio/uio_pci_generic: Introduce refcnt on open/release Yao Hongbo
2022-03-31 20:29 ` Michael S. Tsirkin
2022-04-01 6:17 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkaZBWqcOSBO28HU@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alikernel-developer@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=yaohongbo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.