From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 0/2] mfd: twlx030: i2c remove callback cleanup
Date: Fri, 1 Apr 2022 08:46:06 +0100 [thread overview]
Message-ID: <Ykatvp3RuNA8IXZ7@google.com> (raw)
In-Reply-To: <20220331131722.wt5uik3izzr7kewq@pengutronix.de>
On Thu, 31 Mar 2022, Uwe Kleine-König wrote:
> On Thu, Jan 13, 2022 at 11:14:28AM +0100, Uwe Kleine-König wrote:
> > Hello,
> >
> > the remove paths of the twl4030 chip can fail and then returns an error
> > code in twl_remove() early. This isn't a good thing, because the device
> > will still go away with some resources not freed.
> > For the twl6030 this cannot happen, and the first patch is just a small
> > cleanup. For the twl4030 the situation is improved a bit: When the
> > failure happens, the dummy slave devices are removed now.
> >
> > Note that twl4030_exit_irq() is incomplete. The irq isn't freed and
> > maybe some more cleanup is missing which might boom if an irq triggers
> > after the device is removed. Not sure that twl6030_exit_irq() is better
> > in this regard.
> >
> > I noticed this issue because I work on making i2c_driver::remove return
> > void as returning a value != 0 there is almost always an error attached
> > to wrong expectations.
>
> It's one merge window ago now that I sent these two patches and didn't
> get any feedback. Did this series fell through the cracks?
Yes they did.
Feel free to submit [RESEND]s any time after 2 weeks with no reply.
They are now on my TODO list.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2022-04-01 7:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 10:14 [PATCH 0/2] mfd: twlx030: i2c remove callback cleanup Uwe Kleine-König
2022-01-13 10:14 ` [PATCH 1/2] mfd: twl6030: Make twl6030_exit_irq() return void Uwe Kleine-König
2022-04-28 16:24 ` Lee Jones
2022-05-23 21:24 ` Uwe Kleine-König
2022-05-24 8:01 ` Lee Jones
2022-01-13 10:14 ` [PATCH 2/2] mfd: twl4030: Make twl4030_exit_irq() " Uwe Kleine-König
2022-04-28 16:24 ` Lee Jones
2022-03-31 13:17 ` [PATCH 0/2] mfd: twlx030: i2c remove callback cleanup Uwe Kleine-König
2022-04-01 7:46 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykatvp3RuNA8IXZ7@google.com \
--to=lee.jones@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.