From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sandipan Patra <spatra@nvidia.com>
Cc: treding@nvidia.com, jonathanh@nvidia.com, digetx@gmail.com,
ulf.hansson@linaro.org, cai.huoqing@linux.dev, bbasu@nvidia.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch V3] soc/tegra: pmc: update Tegra234 reset sources
Date: Fri, 1 Apr 2022 20:36:32 +0300 [thread overview]
Message-ID: <Ykc4IBtQK1voGTGL@smile.fi.intel.com> (raw)
In-Reply-To: <20220401143343.31989-1-spatra@nvidia.com>
On Fri, Apr 01, 2022 at 08:03:43PM +0530, Sandipan Patra wrote:
> Reset_sources list is updated to add all reset sources
> and removing ones that do not actually exist.
This LGTM, but I am not a maintainer.
So, if it helps and FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Sandipan Patra <spatra@nvidia.com>
> ---
> Update on V3 patch:
> Added more frequent comments to specify every 8 offsets
> Update on V2 patch:
> space inside comment and
> Changed decimal to hexadecimal notation in the comments.
>
> drivers/soc/tegra/pmc.c | 33 +++++++++++++++++++++++++--------
> 1 file changed, 25 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index fdf508e03400..c01db5309b5e 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -3766,7 +3766,7 @@ static const struct tegra_pmc_regs tegra234_pmc_regs = {
> };
>
> static const char * const tegra234_reset_sources[] = {
> - "SYS_RESET_N",
> + "SYS_RESET_N", /* 0x0 */
> "AOWDT",
> "BCCPLEXWDT",
> "BPMPWDT",
> @@ -3774,19 +3774,36 @@ static const char * const tegra234_reset_sources[] = {
> "SPEWDT",
> "APEWDT",
> "LCCPLEXWDT",
> - "SENSOR",
> - "AOTAG",
> - "VFSENSOR",
> + "SENSOR", /* 0x8 */
> + NULL,
> + NULL,
> "MAINSWRST",
> "SC7",
> "HSM",
> - "CSITE",
> + NULL,
> "RCEWDT",
> - "PVA0WDT",
> - "PVA1WDT",
> - "L1A_ASYNC",
> + NULL, /* 0x10 */
> + NULL,
> + NULL,
> "BPMPBOOT",
> "FUSECRC",
> + "DCEWDT",
> + "PSCWDT",
> + "PSC",
> + "CSITE_SW", /* 0x18 */
> + "POD",
> + "SCPM",
> + "VREFRO_POWERBAD",
> + "VMON",
> + "FMON",
> + "FSI_R5WDT",
> + "FSI_THERM",
> + "FSI_R52C0WDT", /* 0x20 */
> + "FSI_R52C1WDT",
> + "FSI_R52C2WDT",
> + "FSI_R52C3WDT",
> + "FSI_FMON",
> + "FSI_VMON", /* 0x25 */
> };
>
> static const struct tegra_wake_event tegra234_wake_events[] = {
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-04-01 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 14:33 [Patch V3] soc/tegra: pmc: update Tegra234 reset sources Sandipan Patra
2022-04-01 17:36 ` Andy Shevchenko [this message]
2022-04-06 13:05 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykc4IBtQK1voGTGL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bbasu@nvidia.com \
--cc=cai.huoqing@linux.dev \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=spatra@nvidia.com \
--cc=treding@nvidia.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.