From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89767C433EF for ; Fri, 1 Apr 2022 20:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347423AbiDAU3M (ORCPT ); Fri, 1 Apr 2022 16:29:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352718AbiDAU21 (ORCPT ); Fri, 1 Apr 2022 16:28:27 -0400 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 569AD58395; Fri, 1 Apr 2022 13:26:36 -0700 (PDT) Received: by mail-oi1-f173.google.com with SMTP id e189so3917775oia.8; Fri, 01 Apr 2022 13:26:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T+0PW5LNkz/Ox7qIIpulz8qqFC9xWysNmc+x8WFttFI=; b=5lsKgLsuYt89sUkh4navtKdOnEt+IFXgqV50aak7qlru0y4CW+sBtVGH1XZ0gxsEcl sxtAzqPlJixT3dL/EYHhWHugeEzr7lDVSs1chJcSYi3+wEIMuaIYCnrIR7bsxsezhadH k8mm5HDPu6B7rrB5M+GusidyWZT+7Qxot3rP+QZd+jROfXVtSAkzYRZjkFRtH+ntHdBI XN4XfVWtfLAY/VEEsGyjgdpzLRe9EZtvkJzpEYdMTDdBq8d9IttSlVRFBkOsfVBN1TIN /aumwUd1OF+hin+Q8aGv7gACja0EX4vgrscGvfIcBvWNkNIIuCyJfhugw4N6BDd989bt p6cg== X-Gm-Message-State: AOAM5301GaSTqgwtoPHEgHQuMfvSJ5ph3XaoloyTOxlTyDsXjPZ1ezD4 Y9AzFS8S/ERTzPWJGRu4EQ== X-Google-Smtp-Source: ABdhPJw+tFR9vw806n3+CZYVqImyHzmW91QrWT8iYynrciq4HEd6xNf3xACCW870T49+LpN9xAOA4Q== X-Received: by 2002:a05:6808:238e:b0:2ec:e0ee:abe4 with SMTP id bp14-20020a056808238e00b002ece0eeabe4mr5792022oib.187.1648844796079; Fri, 01 Apr 2022 13:26:36 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y3-20020a056870e50300b000d9be6436f1sm1415409oag.29.2022.04.01.13.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 13:26:34 -0700 (PDT) Received: (nullmailer pid 3526180 invoked by uid 1000); Fri, 01 Apr 2022 20:26:33 -0000 Date: Fri, 1 Apr 2022 15:26:33 -0500 From: Rob Herring To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v8 8/8] PCI: imx6: Add compliance tests mode support Message-ID: References: <1645760667-10510-1-git-send-email-hongxing.zhu@nxp.com> <1645760667-10510-9-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1645760667-10510-9-git-send-email-hongxing.zhu@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Feb 25, 2022 at 11:44:27AM +0800, Richard Zhu wrote: > Refer to the Chapter 3.2 System Board Signal Quality of PCI Express > Architecture PHY Test Specification Revision 2.0. > > Signal quality tests (for example: jitter, differential eye opening and > so on) can be executed with devices in the polling.compliance state. > > To let the device support polling.compliance state, the clocks and powers > shouldn't be turned off when the probe of device driver fails. > > Based on CLB (Compliance Load Board) Test Fixture and so on test > equipments, the PHY link would be down during the compliance tests. > Refer to this scenario, add the i.MX PCIe compliance tests mode enable > support, and keep the clocks and powers on, and finish the driver probe > without error return. How is this specific to i.MX? If there's a need for compliance test mode, then shouldn't it be common? However, while your usecase is compliance testing, there doesn't seem to be any need for the kernel to know what the usecase is. In the same series you've argued both ways. You need the driver to probe successfully with no link and you need it to shutdown on no link. > > Use the "pci_imx6.compliance=1" in kernel command line to enable the > compliance tests mode. > > Signed-off-by: Richard Zhu > --- > drivers/pci/controller/dwc/pci-imx6.c | 47 ++++++++++++++++++--------- > 1 file changed, 31 insertions(+), 16 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F7B1C433F5 for ; Fri, 1 Apr 2022 20:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZXbIqtcF2soHALD9++FOwqvgi0CUQSLODgfY3NJfaUs=; b=SbnPgKBcNxU90C b1Dn4AauX7YC0ZV6ywnW6WjLmu2pP7cSK40xNp7xyf/ld9FlvGmL2syv4hjRJ3j90IAaPR6lYOTSI /vkcI6ctU0xZjWAx3Edk52vX4Zf1njs7URxvwpdNlCmnjXHicKNW/4aRtK36HBjF9URFH2BRdEzlf 8gF5LRpAnV8LRvFbC5j83dEZxzWeG6b7Pia824Xs8fo0L9J60IEh0X5NF6RIkqbLgJyUudyLVCwTC hSU428FbxJHYchlY9jY46O4PqA22wYVM3NT5TIyZ24IINt5IcymVEmWXoLrb0TjEntrvqNvyqpPRh +gAAlUIDQaAXUnimSOfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naO4e-007G6p-EL; Fri, 01 Apr 2022 20:40:49 +0000 Received: from mail-oi1-f182.google.com ([209.85.167.182]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naNqx-0079d7-6O for linux-arm-kernel@lists.infradead.org; Fri, 01 Apr 2022 20:26:40 +0000 Received: by mail-oi1-f182.google.com with SMTP id q189so3919335oia.9 for ; Fri, 01 Apr 2022 13:26:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T+0PW5LNkz/Ox7qIIpulz8qqFC9xWysNmc+x8WFttFI=; b=MeSjGqOgAMRFPzmkoTUe5oB7YzOAR8ZOc2nks1zMZuaWpwBBMGQHAYJhPt+NQfWhnL KDfCd62YdTTe2nuchjMTKLBsGYLIZqa+FhIQW/p0RgmwZ0Tvi+Lg8G6hGo6xWxJb4Hru wD+ut5I7n/lSNv1sQzhSuC1Bx9tBu4Mzh70IvvR9wAzugc8oZqLB+ak7mh5IFElNzTr9 hGO7W1TjFf/B0STgrM19FXQ0WprYKrubkm0rjYvq8vALJRfaFz+QCz477XACwoWNHjLf HZCfdzg1ZOOVEXh8z9eITS2xkPS2AlQJvmZ5ywfdhhtzfP1a7TxcQDrGjJBJ5Knlq3an rnGQ== X-Gm-Message-State: AOAM531ehji2RqSbVaIMsjhmjFoHNA4ulxLkBINHVV2Vhkk8sEMUQhVd Dpp0SJ/GfF+Efti7pd3ZNQ== X-Google-Smtp-Source: ABdhPJw+tFR9vw806n3+CZYVqImyHzmW91QrWT8iYynrciq4HEd6xNf3xACCW870T49+LpN9xAOA4Q== X-Received: by 2002:a05:6808:238e:b0:2ec:e0ee:abe4 with SMTP id bp14-20020a056808238e00b002ece0eeabe4mr5792022oib.187.1648844796079; Fri, 01 Apr 2022 13:26:36 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y3-20020a056870e50300b000d9be6436f1sm1415409oag.29.2022.04.01.13.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 13:26:34 -0700 (PDT) Received: (nullmailer pid 3526180 invoked by uid 1000); Fri, 01 Apr 2022 20:26:33 -0000 Date: Fri, 1 Apr 2022 15:26:33 -0500 From: Rob Herring To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: Re: [PATCH v8 8/8] PCI: imx6: Add compliance tests mode support Message-ID: References: <1645760667-10510-1-git-send-email-hongxing.zhu@nxp.com> <1645760667-10510-9-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1645760667-10510-9-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_132639_263194_112802EC X-CRM114-Status: GOOD ( 20.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 25, 2022 at 11:44:27AM +0800, Richard Zhu wrote: > Refer to the Chapter 3.2 System Board Signal Quality of PCI Express > Architecture PHY Test Specification Revision 2.0. > > Signal quality tests (for example: jitter, differential eye opening and > so on) can be executed with devices in the polling.compliance state. > > To let the device support polling.compliance state, the clocks and powers > shouldn't be turned off when the probe of device driver fails. > > Based on CLB (Compliance Load Board) Test Fixture and so on test > equipments, the PHY link would be down during the compliance tests. > Refer to this scenario, add the i.MX PCIe compliance tests mode enable > support, and keep the clocks and powers on, and finish the driver probe > without error return. How is this specific to i.MX? If there's a need for compliance test mode, then shouldn't it be common? However, while your usecase is compliance testing, there doesn't seem to be any need for the kernel to know what the usecase is. In the same series you've argued both ways. You need the driver to probe successfully with no link and you need it to shutdown on no link. > > Use the "pci_imx6.compliance=1" in kernel command line to enable the > compliance tests mode. > > Signed-off-by: Richard Zhu > --- > drivers/pci/controller/dwc/pci-imx6.c | 47 ++++++++++++++++++--------- > 1 file changed, 31 insertions(+), 16 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel