All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] drm: of: fix device_node_continue.cocci warnings
Date: Sun, 03 Apr 2022 02:36:17 +0800	[thread overview]
Message-ID: <YkiXoboiaXbaBTpD@398381435c19> (raw)
In-Reply-To: <202204030210.J2kMG0rF-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
CC: Maxime Ripard <maxime@cerno.tech>
CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
CC: Thomas Zimmermann <tzimmermann@suse.de>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: dri-devel(a)lists.freedesktop.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/drm_of.c:297:2-13: ERROR: probable double put.

 Device node iterators put the previous value of the index variable, so an
 explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Fixes: 67bae5f28c89 ("drm: of: Properly try all possible cases for bridge/panel detection")
CC: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   e5071887cd2296a7704dbcd10c1cedf0f11cdbd5
commit: 67bae5f28c895f8737a1974c3f31cf12b9170b14 [14515/15002] drm: of: Properly try all possible cases for bridge/panel detection
:::::: branch date: 2 days ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/gpu/drm/drm_of.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -294,7 +294,6 @@ int drm_of_find_panel_or_bridge(const st
 			continue;
 
 		ret = find_panel_or_bridge(node, panel, bridge);
-		of_node_put(node);
 
 		/* Stop at the first found occurrence. */
 		if (!ret)

      reply	other threads:[~2022-04-02 18:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-02 18:43 [linux-next:master 14515/15002] drivers/gpu/drm/drm_of.c:297:2-13: ERROR: probable double put kernel test robot
2022-04-02 18:36 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkiXoboiaXbaBTpD@398381435c19 \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.