From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Stijn Tintel <stijn@linux-ipv6.be>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
pali@kernel.org, kabel@kernel.org, pabeni@redhat.com,
kuba@kernel.org, davem@davemloft.net, hkallweit1@gmail.com,
andrew@lunn.ch
Subject: Re: [PATCH] net: phy: marvell: add 88E1543 support
Date: Sun, 3 Apr 2022 20:01:33 +0100 [thread overview]
Message-ID: <YknvDRbRznWZpstM@shell.armlinux.org.uk> (raw)
In-Reply-To: <fa04f389-df01-4838-7304-2fb43b919b98@linux-ipv6.be>
On Sun, Apr 03, 2022 at 09:30:06PM +0300, Stijn Tintel wrote:
> On 3/04/2022 21:19, Russell King (Oracle) wrote:
> > Hi,
> >
> > On Sun, Apr 03, 2022 at 08:29:36PM +0300, Stijn Tintel wrote:
> >> Add support for the Marvell Alaska 88E1543 PHY used in the WatchGuard
> >> Firebox M200 and M300.
> > Looking at the IDs, this PHY should already be supported - reporting as
> > an 88E1545. Why do you need this patch?
> >
> Thanks for pointing that out, you're right. Please disregard the patch.
> Would it be acceptable to change the name member to "Marvell
> 88E1543/88E1545" to make this more obvious?
Unfortuantely not, the driver name is used in sysfs, and as I'm sure
you're aware, "/" is a pathname element separator and thus can't be
used.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-04-03 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 17:29 [PATCH] net: phy: marvell: add 88E1543 support Stijn Tintel
2022-04-03 18:19 ` Russell King (Oracle)
2022-04-03 18:30 ` Stijn Tintel
2022-04-03 19:01 ` Russell King (Oracle) [this message]
2022-04-03 19:54 ` Andrew Lunn
2022-04-03 19:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YknvDRbRznWZpstM@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pali@kernel.org \
--cc=stijn@linux-ipv6.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.