All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] Rewrite userns06.c using new LTP API
Date: Mon, 4 Apr 2022 14:55:41 +0200	[thread overview]
Message-ID: <YkrqzV+W2qYKJuIw@pevik> (raw)
In-Reply-To: <348d5c14-97e2-7c23-9666-92ba77354417@suse.com>

Hi Andrea,

> Hi Petr,

> can TST_TEST_CONF be used even if TST_NO_DEFAULT_MAIN is defined?
I'm sorry, you're right it can't be used like that.

TST_NO_DEFAULT_MAIN could be defined only in #ifdef HAVE_LIBCAP:

#include "config.h"
#ifdef HAVE_LIBCAP

#define _GNU_SOURCE
#define TST_NO_DEFAULT_MAIN
#include "tst_test.h"
...
#else
#include "tst_test.h"
TST_TEST_TCONF("System is missing libcap");

But that's not much improvement indeed, thus lets ignore it.

Also, #define _GNU_SOURCE should be IMHO before any first include,
i.e. even before tst_test.h (it includes many system headers).

Kind regards,
Petr

> Andrea

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-04-04 12:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01  5:08 [LTP] [PATCH v4] Rewrite userns06.c using new LTP API Andrea Cervesato
2022-04-04 10:33 ` Petr Vorel
2022-04-04 10:52   ` Andrea Cervesato via ltp
2022-04-04 12:55     ` Petr Vorel [this message]
2022-04-19  7:22       ` Petr Vorel
2022-04-19  7:36         ` Andrea Cervesato via ltp
2022-04-19 12:16 ` Cyril Hrubis
  -- strict thread matches above, loose matches on Subject: below --
2022-04-26  8:47 Andrea Cervesato
2022-04-26 13:57 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkrqzV+W2qYKJuIw@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.