From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Mon, 4 Apr 2022 16:45:50 +0200 Subject: [PATCH] serial: 8250_aspeed_vuart: Fix potential NULL dereference in aspeed_vuart_probe In-Reply-To: <20220404143842.16960-1-linmq006@gmail.com> References: <20220404143842.16960-1-linmq006@gmail.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Apr 04, 2022 at 02:38:40PM +0000, Miaoqian Lin wrote: > platform_get_resource() may fail and return NULL, so we should > better check it's return value to avoid a NULL pointer dereference. > > Fixes: 54da3e381c2b ("serial: 8250_aspeed_vuart: use UPF_IOREMAP to set up register mapping") > Signed-off-by: Miaoqian Lin > --- > drivers/tty/serial/8250/8250_aspeed_vuart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c > index 93fe10c680fb..9d2a7856784f 100644 > --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c > +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c > @@ -429,6 +429,8 @@ static int aspeed_vuart_probe(struct platform_device *pdev) > timer_setup(&vuart->unthrottle_timer, aspeed_vuart_unthrottle_exp, 0); > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return -EINVAL; How did you test this change was correct? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81CE3C433FE for ; Mon, 4 Apr 2022 14:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378162AbiDDOui (ORCPT ); Mon, 4 Apr 2022 10:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378258AbiDDOto (ORCPT ); Mon, 4 Apr 2022 10:49:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFA026449; Mon, 4 Apr 2022 07:45:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 858B5B815AA; Mon, 4 Apr 2022 14:45:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A597FC340EE; Mon, 4 Apr 2022 14:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649083553; bh=k9WAcFBCFfb+3TY2XrOQKaVZhD+Dcxfd/5cZ6RmH+D4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F4SvhD9u8ufJSVbfTnoJX2D4cS2Z0ggUcxa/IR5dnmJ8NSOTR7xfILZAzjGHcr/JW e4M47qdBhXdxqmjzbckSKIsTr4tjgA70Q7WU5fIEpfD8ffMjmRhz8SnPZkT5nDtksg SsrhO+Iqx038tynbid79VN1Dcu/cAwwcduH2S0nE= Date: Mon, 4 Apr 2022 16:45:50 +0200 From: Greg Kroah-Hartman To: Miaoqian Lin Cc: Jiri Slaby , Joel Stanley , Andrew Jeffery , Zev Weiss , Johan Hovold , Yang Guang , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: 8250_aspeed_vuart: Fix potential NULL dereference in aspeed_vuart_probe Message-ID: References: <20220404143842.16960-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220404143842.16960-1-linmq006@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Mon, Apr 04, 2022 at 02:38:40PM +0000, Miaoqian Lin wrote: > platform_get_resource() may fail and return NULL, so we should > better check it's return value to avoid a NULL pointer dereference. > > Fixes: 54da3e381c2b ("serial: 8250_aspeed_vuart: use UPF_IOREMAP to set up register mapping") > Signed-off-by: Miaoqian Lin > --- > drivers/tty/serial/8250/8250_aspeed_vuart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c > index 93fe10c680fb..9d2a7856784f 100644 > --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c > +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c > @@ -429,6 +429,8 @@ static int aspeed_vuart_probe(struct platform_device *pdev) > timer_setup(&vuart->unthrottle_timer, aspeed_vuart_unthrottle_exp, 0); > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return -EINVAL; How did you test this change was correct? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E9E9C433F5 for ; Mon, 4 Apr 2022 14:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j4AWS1w0TEZ+mEQ1d5Sr+1Pp8HWIMNjKllgUdOelj4E=; b=2hbp77ZpfmxIIM xG8m9+vkQkaX5o6iTpPwMspP4/GmFJbvs4sZtHV0Wr9M25ccc7kErGKaAglTK1GUHtOHkEQXa8LYM aURdtpYG8HzmAHU19jHoNE+7m2+CZ7QURcTWOEYl41NCV61yb+XDYLlzL2DVTg4Z5erl+u+KO8VL1 hrLqhmi3UJPOL0wjtWvT4hOilhDm2Qfw/PfgteS3hGzQ3xeGDRUV/wngzub70Vw8LRJOK6WwA+W8+ pVyMhyyOEPU3YF+YDomQ48MmNg9ZXAryPTQ2wbrJFMeHNzwh63If3MODKHMS9w+YbhDZ2chVddoof Gk0rf+cotHmrRt8Vk+aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbNxv-00FPYG-3B; Mon, 04 Apr 2022 14:45:59 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbNxs-00FPXd-6f for linux-arm-kernel@lists.infradead.org; Mon, 04 Apr 2022 14:45:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 89CA4B8171F; Mon, 4 Apr 2022 14:45:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A597FC340EE; Mon, 4 Apr 2022 14:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649083553; bh=k9WAcFBCFfb+3TY2XrOQKaVZhD+Dcxfd/5cZ6RmH+D4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F4SvhD9u8ufJSVbfTnoJX2D4cS2Z0ggUcxa/IR5dnmJ8NSOTR7xfILZAzjGHcr/JW e4M47qdBhXdxqmjzbckSKIsTr4tjgA70Q7WU5fIEpfD8ffMjmRhz8SnPZkT5nDtksg SsrhO+Iqx038tynbid79VN1Dcu/cAwwcduH2S0nE= Date: Mon, 4 Apr 2022 16:45:50 +0200 From: Greg Kroah-Hartman To: Miaoqian Lin Cc: Jiri Slaby , Joel Stanley , Andrew Jeffery , Zev Weiss , Johan Hovold , Yang Guang , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: 8250_aspeed_vuart: Fix potential NULL dereference in aspeed_vuart_probe Message-ID: References: <20220404143842.16960-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220404143842.16960-1-linmq006@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_074556_424364_DBB49DFD X-CRM114-Status: GOOD ( 17.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 04, 2022 at 02:38:40PM +0000, Miaoqian Lin wrote: > platform_get_resource() may fail and return NULL, so we should > better check it's return value to avoid a NULL pointer dereference. > > Fixes: 54da3e381c2b ("serial: 8250_aspeed_vuart: use UPF_IOREMAP to set up register mapping") > Signed-off-by: Miaoqian Lin > --- > drivers/tty/serial/8250/8250_aspeed_vuart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c > index 93fe10c680fb..9d2a7856784f 100644 > --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c > +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c > @@ -429,6 +429,8 @@ static int aspeed_vuart_probe(struct platform_device *pdev) > timer_setup(&vuart->unthrottle_timer, aspeed_vuart_unthrottle_exp, 0); > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return -EINVAL; How did you test this change was correct? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel