From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 2/2] docs: dt: writing-schema: mention coding style
Date: Mon, 4 Apr 2022 17:52:03 -0500 [thread overview]
Message-ID: <Ykt2k1v7IHopnlK0@robh.at.kernel.org> (raw)
In-Reply-To: <20220403081849.8051-2-krzysztof.kozlowski@linaro.org>
On Sun, 03 Apr 2022 10:18:49 +0200, Krzysztof Kozlowski wrote:
> Mention the usage of YAML coding style. Describe explicitly that
> four-space indentation in DTS examples is preferred, because:
> 1. The YAML's default two-space indentation for DTS code makes it
> significantly less readable.
> 2. Linux coding style tabs would introduce inconsistency (entire file is
> indented with spaces).
> 3. On the other hand, eight spaces would not align with example's
> opening ' - |' part. Four spaces makes the code nicely aligned with
> it.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/example-schema.yaml | 14 +++++++-------
> .../devicetree/bindings/writing-schema.rst | 6 ++++++
> 2 files changed, 13 insertions(+), 7 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2022-04-04 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 8:18 [PATCH 1/2] docs: dt: writing-bindings: describe typical cases Krzysztof Kozlowski
2022-04-03 8:18 ` [PATCH 2/2] docs: dt: writing-schema: mention coding style Krzysztof Kozlowski
2022-04-04 22:52 ` Rob Herring [this message]
2022-04-04 22:51 ` [PATCH 1/2] docs: dt: writing-bindings: describe typical cases Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykt2k1v7IHopnlK0@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.