All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	outreachy@lists.linux.dev
Subject: Re: [PATCH 4/5] staging: rtl8723bs: fix indentation
Date: Tue, 5 Apr 2022 16:05:40 +0200	[thread overview]
Message-ID: <YkxMtPimZLxAlkgg@kroah.com> (raw)
In-Reply-To: <3bb9687a1057619334d95832f803c9b8d7e7fa63.1649128267.git.sevinj.aghayeva@gmail.com>

On Mon, Apr 04, 2022 at 11:16:11PM -0400, Sevinj Aghayeva wrote:
> Adhere to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> WARNING: suspect code indent for conditional statements
> 
> Signed-off-by: Sevinj Aghayeva <sevinj.aghayeva@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index c06be65b45cf..5eddff488f27 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -5145,9 +5145,9 @@ void link_timer_hdl(struct timer_list *t)
>  		if (++pmlmeinfo->reauth_count > REAUTH_LIMIT) {
>  			/* if (pmlmeinfo->auth_algo != dot11AuthAlgrthm_Auto) */
>  			/*  */
> -				pmlmeinfo->state = 0;
> -				report_join_res(padapter, -1);
> -				return;
> +			pmlmeinfo->state = 0;
> +			report_join_res(padapter, -1);
> +			return;
>  			/*  */
>  			/* else */
>  			/*  */

Please remove these comments around here at the same time, as the
indentation did make sense with those there, but now it's really messy.

thanks,

greg k-h

  reply	other threads:[~2022-04-05 14:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05  3:16 [PATCH 0/5] rtl8723bs cleanup Sevinj Aghayeva
2022-04-05  3:16 ` [PATCH 1/5] staging: rtl8723bs: remove redundant braces in if statements Sevinj Aghayeva
2022-04-05  3:16 ` [PATCH 2/5] staging: rtl8723bs: remove redundant else branches Sevinj Aghayeva
2022-04-05  3:16 ` [PATCH 3/5] staging: rtl8723bs: remove return from a function returning void Sevinj Aghayeva
2022-04-05  3:16 ` [PATCH 4/5] staging: rtl8723bs: fix indentation Sevinj Aghayeva
2022-04-05 14:05   ` Greg Kroah-Hartman [this message]
2022-04-05  3:16 ` [PATCH 5/5] staging: rtl8723bs: remove space after function name Sevinj Aghayeva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkxMtPimZLxAlkgg@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=sevinj.aghayeva@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.