All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Xiao Yang <yangx.jy@fujitsu.com>
Cc: linux-rdma@vger.kernel.org, yanjun.zhu@linux.dev,
	rpearsonhpe@gmail.com, jgg@nvidia.com, y-goto@fujitsu.com,
	lizhijian@fujitsu.com, tomasz.gromadzki@intel.com,
	ira.weiny@intel.com
Subject: Re: [PATCH v4 0/3] RDMA/rxe: Add RDMA Atomic Write operation
Date: Wed, 20 Apr 2022 09:54:34 +0300	[thread overview]
Message-ID: <Yl+uKqWp1pj2doGt@unreal> (raw)
In-Reply-To: <20220418061244.89025-1-yangx.jy@fujitsu.com>

On Mon, Apr 18, 2022 at 02:12:41PM +0800, Xiao Yang wrote:
> The IB SPEC v1.5[1] defined new RDMA Atomic Write operation. This
> patchset makes SoftRoCE support new RDMA Atomic Write on RC service.
> 
> I add ibv_wr_rdma_atomic_write() and a rdma_atomic_write example on my
> rdma-core repository[2].  You can verify the patchset by building and
> running the rdma_atomic_write example.
> server:
> $ ./rdma_atomic_write_server -s [server_address] -p [port_number]
> client:
> $ ./rdma_atomic_write_client -s [server_address] -p [port_number]

We need PR to official rdma-core repo with pyverbs test to consider this
code for merge.

Thanks

> 
> [1]: https://www.infinibandta.org/wp-content/uploads/2021/08/IBTA-Overview-of-IBTA-Volume-1-Release-1.5-and-MPE-2021-08-17-Secure.pptx
> [2]: https://github.com/yangx-jy/rdma-core/tree/new_api_with_point
> 
> v3->v4:
> 1) Rebase on current wip/jgg-for-next
> 2) Fix a compiler error on 32-bit arch (e.g. parisc) by disabling RDMA Atomic Write
> 3) Replace 64-bit value with 8-byte array for RDMA Atomic Write
> 
> V2->V3:
> 1) Rebase
> 2) Add RDMA Atomic Write attribute for rxe device
> 
> V1->V2:
> 1) Set IB_OPCODE_RDMA_ATOMIC_WRITE to 0x1D
> 2) Add rdma.atomic_wr in struct rxe_send_wr and use it to pass the atomic write value
> 3) Use smp_store_release() to ensure that all prior operations have completed
> 
> Xiao Yang (3):
>   RDMA/rxe: Rename send_atomic_ack() and atomic member of struct
>     resp_res
>   RDMA/rxe: Support RDMA Atomic Write operation
>   RDMA/rxe: Add RDMA Atomic Write attribute for rxe device
> 
>  drivers/infiniband/sw/rxe/rxe_comp.c   |  4 ++
>  drivers/infiniband/sw/rxe/rxe_opcode.c | 19 ++++++++
>  drivers/infiniband/sw/rxe/rxe_opcode.h |  3 ++
>  drivers/infiniband/sw/rxe/rxe_param.h  |  5 +++
>  drivers/infiniband/sw/rxe/rxe_qp.c     |  4 +-
>  drivers/infiniband/sw/rxe/rxe_req.c    | 13 +++++-
>  drivers/infiniband/sw/rxe/rxe_resp.c   | 61 ++++++++++++++++++++------
>  drivers/infiniband/sw/rxe/rxe_verbs.h  |  2 +-
>  include/rdma/ib_pack.h                 |  2 +
>  include/rdma/ib_verbs.h                |  3 ++
>  include/uapi/rdma/ib_user_verbs.h      |  4 ++
>  include/uapi/rdma/rdma_user_rxe.h      |  1 +
>  12 files changed, 103 insertions(+), 18 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> 

  parent reply	other threads:[~2022-04-20  6:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18  6:12 [PATCH v4 0/3] RDMA/rxe: Add RDMA Atomic Write operation Xiao Yang
2022-04-18  6:12 ` [PATCH v4 1/3] RDMA/rxe: Rename send_atomic_ack() and atomic member of struct resp_res Xiao Yang
2022-04-18  6:12 ` [PATCH v4 2/3] RDMA/rxe: Support RDMA Atomic Write operation Xiao Yang
2022-04-18  6:12 ` [PATCH v4 3/3] RDMA/rxe: Add RDMA Atomic Write attribute for rxe device Xiao Yang
2022-04-20  6:54 ` Leon Romanovsky [this message]
2022-04-20  7:08   ` [PATCH v4 0/3] RDMA/rxe: Add RDMA Atomic Write operation yangx.jy
2022-04-27  7:46     ` yangx.jy
2022-05-13  3:46 ` yangx.jy
2022-05-13 11:46   ` Jason Gunthorpe
2022-05-13 15:45     ` Bob Pearson
2022-07-04 13:45 ` Jason Gunthorpe
2022-07-05  1:50   ` yangx.jy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yl+uKqWp1pj2doGt@unreal \
    --to=leon@kernel.org \
    --cc=ira.weiny@intel.com \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=rpearsonhpe@gmail.com \
    --cc=tomasz.gromadzki@intel.com \
    --cc=y-goto@fujitsu.com \
    --cc=yangx.jy@fujitsu.com \
    --cc=yanjun.zhu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.