From: Heiko Carstens <hca@linux.ibm.com>
To: Tony Krowiak <akrowiak@linux.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
linux-s390@vger.kernel.org,
Harald Freudenberger <freude@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration
Date: Mon, 18 Apr 2022 19:00:59 +0200 [thread overview]
Message-ID: <Yl2ZS7lyzyit9lbk@osiris> (raw)
In-Reply-To: <2440b3f3-6961-4091-438f-7120b9177164@linux.ibm.com>
On Mon, Apr 18, 2022 at 10:23:38AM -0400, Tony Krowiak wrote:
> Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
>
> On 4/13/22 5:44 AM, Thomas Huth wrote:
> > The vfio_ap module tries to register for the vfio_ap bus - but that's
> > the interface that it provides itself, so this does not make much sense,
> > thus let's simply drop this statement now.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > See also my previous patch to register it for the "ap" bus instead:
> > https://lore.kernel.org/linux-s390/20211201141110.94636-1-thuth@redhat.com/
> > ... but since it has been decided to not auto-load the module uncondi-
> > tionally, I'd like to suggest to rather drop this line now instead.
> >
> > drivers/s390/crypto/vfio_ap_drv.c | 2 --
> > 1 file changed, 2 deletions(-)
...
Applied, thanks.
prev parent reply other threads:[~2022-04-18 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 9:44 [PATCH] s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration Thomas Huth
2022-04-18 14:23 ` Tony Krowiak
2022-04-18 17:00 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl2ZS7lyzyit9lbk@osiris \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.