From: Matthias Kaehlcke <mka@chromium.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: core: Replace _regulator_enable_delay() with fsleep()
Date: Mon, 18 Apr 2022 15:53:18 -0700 [thread overview]
Message-ID: <Yl3r3tiJ6uFTqbd2@google.com> (raw)
In-Reply-To: <20220418141158.2.I31ef0014c9597d53722ab513890f839f357fdfb3@changeid>
On Mon, Apr 18, 2022 at 02:12:40PM -0700, Brian Norris wrote:
> fsleep() was designed to handle exactly the same thing as
> _regulator_enable_delay(): flexible sleep lengths, according to the
> guidelines at Documentation/timers/timers-howto.rst. Let's use it,
> instead of duplicating it.
>
> One notable difference: fsleep() allows a usleep range of twice the
> requested amount instead of a fixed +100us.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2022-04-18 22:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 21:12 [PATCH 1/2] regulator: core: Sleep (not delay) in set_voltage() Brian Norris
2022-04-18 21:12 ` [PATCH 2/2] regulator: core: Replace _regulator_enable_delay() with fsleep() Brian Norris
2022-04-18 22:53 ` Matthias Kaehlcke [this message]
2022-04-20 16:28 ` Mark Brown
2022-04-20 18:24 ` Brian Norris
2022-04-20 21:11 ` Mark Brown
2022-04-18 22:50 ` [PATCH 1/2] regulator: core: Sleep (not delay) in set_voltage() Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl3r3tiJ6uFTqbd2@google.com \
--to=mka@chromium.org \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.