From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF4CC433F5 for ; Fri, 8 Apr 2022 19:52:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239280AbiDHTyD (ORCPT ); Fri, 8 Apr 2022 15:54:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230265AbiDHTyB (ORCPT ); Fri, 8 Apr 2022 15:54:01 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 616FB1403EC for ; Fri, 8 Apr 2022 12:51:57 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id j17so7806312pfi.9 for ; Fri, 08 Apr 2022 12:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+/pEd7g9sc537JcQUHMmtOGN8bVdoYIMIdp7gL4NXVE=; b=PeCCA4cXlctPtn0PwT8WPNO9iuN3Zx2eqNN7U28qU+csc6ly0jDQLJM9RWc2E2KVbJ AcUypMp0H+iw53GHXK5RvKZcP8/rkjWgfvdTjfeEnY9JIOitfRbYudZTS3OeAJfIKjxM uWwxNEXp7qaVn1XNTPUK6KRKStSZpigRp6RLbV/f7qCFJudh74rd+5+3/mBsCYKpDhQr b6MnEYR99I50+9xerR2G3OP8EPzSUpe/XS9ar0zUiH6TJmrdQO8VtaU0clsWQ4qTVfyQ Q7y9WQwRPVDbDiMvzFb+XVfc+9H/+wBfMYeWNQwluw8HVgoUp5aKu0AkxkABo0QFHfkt Lq0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+/pEd7g9sc537JcQUHMmtOGN8bVdoYIMIdp7gL4NXVE=; b=5CuKw8wDhX7zev00Aq8K1M1/jJyxrKRoatsGhimnuQkjfYP5VNU0KTF5LV3pVSfKOO zpVPi6P2ak0veg9gdOlPsUl1X6zpHDniEVioT7yEWasYkE3ztiihssexUJjyMqGoODCe 1Y3TJgDRve/KB5PFSopbxLVBZI9eI/LNdBuA0UXCn5fKEsw32TRwezgTcqY7E/a3R0iE eq09eoEHq/UZGsizPrY1n7rpz12Z0MWiY5A6MixG9erDRtCNPPuLn1CV6zJ7yuwQEUvw 3PZde3u+V9MqaDur9HxHX6NUCvKZ5k6KOQtDcAZS+LnxOTvWWPe3lTjgtJKZAZL98tVY ZkDw== X-Gm-Message-State: AOAM530+Pk8XTdPUg6SCX34hsB5t+kMb3fLaGT9dOF8yNUR53RxE0E74 r6fY6wtzTsJWr30JLwR8dT5tnA== X-Google-Smtp-Source: ABdhPJwPpu43BljXU9K8AZZjz8TjJeuS+SQLKh0qH/CIk0qQsuh7ASoLZtzI2XHsdurOpzw4rkCUUQ== X-Received: by 2002:a63:4642:0:b0:398:b6b9:5f45 with SMTP id v2-20020a634642000000b00398b6b95f45mr17104239pgk.518.1649447516713; Fri, 08 Apr 2022 12:51:56 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id k13-20020aa7820d000000b004fa72a52040sm26955599pfi.172.2022.04.08.12.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 12:51:55 -0700 (PDT) Date: Fri, 8 Apr 2022 19:51:52 +0000 From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Peter Xu , David Matlack , Jim Mattson , David Dunn , Jing Zhang , Junaid Shahid Subject: Re: [PATCH v3 02/11] KVM: selftests: Dump VM stats in binary stats test Message-ID: References: <20220330174621.1567317-1-bgardon@google.com> <20220330174621.1567317-3-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330174621.1567317-3-bgardon@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Mar 30, 2022, Ben Gardon wrote: > Add kvm_util library functions to read KVM stats through the binary > stats interface and then dump them to stdout when running the binary > stats test. Subsequent commits will extend the kvm_util code and use it > to make assertions in a test for NX hugepages. Why? Spamming my console with info that has zero meaning to me and is useless when the test passes is not helpful. Even on failure, I don't see what the user is going to do with this information, all of the asserts are completly unrelated to the stats themselves.