From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: matthias.bgg@gmail.com, mkorpershoek@baylibre.com,
lv.ruyi@zte.com.cn, m.felsch@pengutronix.de,
fengping.yu@mediatek.com, linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: mt6779-keypad: Move iomem pointer to probe function
Date: Fri, 8 Apr 2022 18:33:15 -0700 [thread overview]
Message-ID: <YlDiW0dpZ7A41j/Z@google.com> (raw)
In-Reply-To: <20220406115654.115093-1-angelogioacchino.delregno@collabora.com>
On Wed, Apr 06, 2022 at 01:56:54PM +0200, AngeloGioacchino Del Regno wrote:
> The mmio base address is used for the only purpose of initializing
> regmap for this driver, hence it's not necessary to have it in the
> main driver structure, as it is used only in the probe() callback.
> Move it local to function mt6779_keypad_pdrv_probe().
>
> This commit brings no functional changes.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Applied, thank you.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: matthias.bgg@gmail.com, mkorpershoek@baylibre.com,
lv.ruyi@zte.com.cn, m.felsch@pengutronix.de,
fengping.yu@mediatek.com, linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: mt6779-keypad: Move iomem pointer to probe function
Date: Fri, 8 Apr 2022 18:33:15 -0700 [thread overview]
Message-ID: <YlDiW0dpZ7A41j/Z@google.com> (raw)
In-Reply-To: <20220406115654.115093-1-angelogioacchino.delregno@collabora.com>
On Wed, Apr 06, 2022 at 01:56:54PM +0200, AngeloGioacchino Del Regno wrote:
> The mmio base address is used for the only purpose of initializing
> regmap for this driver, hence it's not necessary to have it in the
> main driver structure, as it is used only in the probe() callback.
> Move it local to function mt6779_keypad_pdrv_probe().
>
> This commit brings no functional changes.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Applied, thank you.
--
Dmitry
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: matthias.bgg@gmail.com, mkorpershoek@baylibre.com,
lv.ruyi@zte.com.cn, m.felsch@pengutronix.de,
fengping.yu@mediatek.com, linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: mt6779-keypad: Move iomem pointer to probe function
Date: Fri, 8 Apr 2022 18:33:15 -0700 [thread overview]
Message-ID: <YlDiW0dpZ7A41j/Z@google.com> (raw)
In-Reply-To: <20220406115654.115093-1-angelogioacchino.delregno@collabora.com>
On Wed, Apr 06, 2022 at 01:56:54PM +0200, AngeloGioacchino Del Regno wrote:
> The mmio base address is used for the only purpose of initializing
> regmap for this driver, hence it's not necessary to have it in the
> main driver structure, as it is used only in the probe() callback.
> Move it local to function mt6779_keypad_pdrv_probe().
>
> This commit brings no functional changes.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Applied, thank you.
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-09 1:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 11:56 [PATCH] Input: mt6779-keypad: Move iomem pointer to probe function AngeloGioacchino Del Regno
2022-04-06 11:56 ` AngeloGioacchino Del Regno
2022-04-06 11:56 ` AngeloGioacchino Del Regno
2022-04-06 12:41 ` Mattijs Korpershoek
2022-04-06 12:41 ` Mattijs Korpershoek
2022-04-06 12:41 ` Mattijs Korpershoek
2022-04-09 1:33 ` Dmitry Torokhov [this message]
2022-04-09 1:33 ` Dmitry Torokhov
2022-04-09 1:33 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlDiW0dpZ7A41j/Z@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=fengping.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lv.ruyi@zte.com.cn \
--cc=m.felsch@pengutronix.de \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.