Re: [RFC PATCH] repo-settings: set defaults even when not in a repo

[Josh Steadmon <steadmon@google.com>]

On 2022.03.29 22:26, Taylor Blau wrote:
> On Tue, Mar 29, 2022 at 11:03:14AM +0200, Ævar Arnfjörð Bjarmason wrote:
> >
> > On Wed, Mar 23 2022, Taylor Blau wrote:
> >
> > >  	/* Boolean config or default, does not cascade (simple)  */
> > >  	repo_cfg_bool(r, "core.commitgraph", &r->settings.core_commit_graph, 1);
> > > +	repo_cfg_int(r, "commitgraph.generationversion", &r->settings.commit_graph_generation_version, 2);
> >
> > If this ends up being kept let's add it to its own commented "section",
> > the comment 2-lines above it is now incorrect.
> 
> Thanks for pointing it out; indeed that comment is definitely stale with
> respect to the newer code. This patch was just a sketch of an
> alternative approach for Josh to consider, so I can't guarantee that it
> isn't immune to nit-picks ;).
> 
> I think that Josh is planning on picking this up, so hopefully he
> doesn't mind applying these and any other touch-ups locally before
> resubmitting.
> 
> (Josh, if you do: thank you very much in advance!)
> 
> Thanks,
> Taylor

Done in V2, to be sent out shortly.