From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CA3CC433EF for ; Sat, 9 Apr 2022 15:12:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230427AbiDIPOu (ORCPT ); Sat, 9 Apr 2022 11:14:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbiDIPOt (ORCPT ); Sat, 9 Apr 2022 11:14:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7885E205DB; Sat, 9 Apr 2022 08:12:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2DC28B80025; Sat, 9 Apr 2022 15:12:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C9E4C385A0; Sat, 9 Apr 2022 15:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649517159; bh=UFt6d+nDavXkqAbzhdwyRWgMrNoPlcPEvcy0Athveww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oSp0Ol0j6f4brdIvMwXtvU9jQGAXTuQ8DfcR/VqOccK8ygkdACqNY2FK8XVVz9vPI /Y75iIIThKW1s4teFOeX1ZUdAyOsNQHIwhiZjPEhBKyO6JCWVQH6a+pDhPO0ytdEHv OUJn7lEsreOtikxhUwLqdQE1Ni9YnimQ54SSjsO4aZkvZc1nlj7lEFj2PCsh7poRFy OIogR3n4ZgrCLabMboEMvEraReJ5dVZwJcoAMhbXX1q/dSohuHLmUlEvTHdqV1K7aI Y+PXhQZ15SpZH7eznEpsFOC2QgX8xWHfgq78tM/67Kh8jMOlft0zILoF3MbpjZWRkL IKp2Cl6LnLvlQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 0EB0240407; Sat, 9 Apr 2022 12:12:37 -0300 (-03) Date: Sat, 9 Apr 2022 12:12:37 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Namhyung Kim , James Clark , linux-perf-users , leo.yan@linaro.com, German Gomez , John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Arnaldo Carvalho de Melo , Ravi Bangoria , linux-arm-kernel@lists.infradead.org, linux-kernel Subject: Re: [PATCH] perf: arm-spe: Fix perf report --mem-mode Message-ID: References: <20220408144056.1955535-1-james.clark@arm.com> <20220409095941.GA1000846@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220409095941.GA1000846@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Sat, Apr 09, 2022 at 05:59:41PM +0800, Leo Yan escreveu: > On Fri, Apr 08, 2022 at 11:13:09AM -0700, Namhyung Kim wrote: > > Hello, > > > > On Fri, Apr 8, 2022 at 7:41 AM James Clark wrote: > > > > > > Since commit bb30acae4c4d ("perf report: Bail out --mem-mode if mem info > > > is not available") "perf mem report" and "perf report --mem-mode" don't > > > allow opening the file unless one of the events has PERF_SAMPLE_DATA_SRC > > > set. > > > > > > SPE doesn't have this set even though synthetic memory data is generated > > > after it is decoded. Fix this issue by setting DATA_SRC on SPE events. > > > This has no effect on the data collected because the SPE driver doesn't > > > do anything with that flag and doesn't generate samples. > > > > > > Fixes: bb30acae4c4d ("perf report: Bail out --mem-mode if mem info is not available") > > > Signed-off-by: James Clark > > > > Acked-by: Namhyung Kim > > Tested-by: Leo Yan > > It's a bit awkward that after the commit bb30acae4c4d we cannot be > backward compatible and any old perf data file will be failed to > support by 'perf mem report' tool. oh well, I think we should put in place a mechanism to run perf record before some change, then make sure that a new perf is able to process it after a rebuild. If its something unsurmountable, then a proper explanation should be done with a workaround to process those older files, even if pointing out to the perf version that is able to process the old file. Anyway, applying this pa tch. - ARnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED5E9C433F5 for ; Sat, 9 Apr 2022 15:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kteAZUCshW9JQnUSrEVwxAEHGr3jZ/Ld+ERa7P22EMQ=; b=quojjOfPIO0gIb zaiYMgKZqWQZ97glJIShPEVSnO+HopW5yyTQFEWsTdUGB3ZqOnRe15HLW0EYyneUJEyRdGZmzYRvV nA5XpGi3K4OfYlV/b0NRMu3UlO9MBj44/1m7obSRjY5c97KZ75/x7o4ep/ikgeNb69P8VuD+2cBFG Ua4Xy4x149sx8mo+y+4ETujWxgvqP13hLZJckGsAsxbK73BFGw4pDoJ14zHp7IhbY0KBMfOGJMfmx esVXOvSCz6TtsDFeCvLn6aAcQoZh4Ba6C9ed5YXwRXxfRuaNBZxrvi17BhlelsiGOuKzLFUGdoQae wdj2qciXPxZ/0k/82gZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndClZ-003NhG-HU; Sat, 09 Apr 2022 15:12:45 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndClV-003Ngy-OL for linux-arm-kernel@bombadil.infradead.org; Sat, 09 Apr 2022 15:12:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MiZZ0egfxPfRtHUaZNUKQS07o8pMhzGwJbO4gcqQdqg=; b=hGMv9wrISgDvfiTSAKFSd4dMHR Dc5JM6Yp6ix27gIsECYYzV6KZCfWFpFOIsfIDSW4YB/whGQchRBWjlB/evKCBfoCRDBaZ4bjP9b++ rQUSsZ4p9yVIPMR0r6ZVGnOtWdb2T1Xxpbt9GqFYHMJ8Sn0cOPEFpw5HIpixMGfmT2SPSCnQswRLE GoKCbpt7VjmVCqg56ISntrFrBIyPCfVRkAeeq05z7B5pe813TjhE9dDfY36pGqonbm4DJp0bqiwnS z9xPrq5e1NoWTaGNhGtdFRLTLUl9bJ6nANwvM6CxmvrHc9fcuuDThrjCJkWUdN4CULBFyH9q/WTMH X6nuVvPQ==; Received: from [187.19.239.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndClU-00AmI6-1V for linux-arm-kernel@lists.infradead.org; Sat, 09 Apr 2022 15:12:40 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 0EB0240407; Sat, 9 Apr 2022 12:12:37 -0300 (-03) Date: Sat, 9 Apr 2022 12:12:37 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Namhyung Kim , James Clark , linux-perf-users , leo.yan@linaro.com, German Gomez , John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Arnaldo Carvalho de Melo , Ravi Bangoria , linux-arm-kernel@lists.infradead.org, linux-kernel Subject: Re: [PATCH] perf: arm-spe: Fix perf report --mem-mode Message-ID: References: <20220408144056.1955535-1-james.clark@arm.com> <20220409095941.GA1000846@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220409095941.GA1000846@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Sat, Apr 09, 2022 at 05:59:41PM +0800, Leo Yan escreveu: > On Fri, Apr 08, 2022 at 11:13:09AM -0700, Namhyung Kim wrote: > > Hello, > > > > On Fri, Apr 8, 2022 at 7:41 AM James Clark wrote: > > > > > > Since commit bb30acae4c4d ("perf report: Bail out --mem-mode if mem info > > > is not available") "perf mem report" and "perf report --mem-mode" don't > > > allow opening the file unless one of the events has PERF_SAMPLE_DATA_SRC > > > set. > > > > > > SPE doesn't have this set even though synthetic memory data is generated > > > after it is decoded. Fix this issue by setting DATA_SRC on SPE events. > > > This has no effect on the data collected because the SPE driver doesn't > > > do anything with that flag and doesn't generate samples. > > > > > > Fixes: bb30acae4c4d ("perf report: Bail out --mem-mode if mem info is not available") > > > Signed-off-by: James Clark > > > > Acked-by: Namhyung Kim > > Tested-by: Leo Yan > > It's a bit awkward that after the commit bb30acae4c4d we cannot be > backward compatible and any old perf data file will be failed to > support by 'perf mem report' tool. oh well, I think we should put in place a mechanism to run perf record before some change, then make sure that a new perf is able to process it after a rebuild. If its something unsurmountable, then a proper explanation should be done with a workaround to process those older files, even if pointing out to the perf version that is able to process the old file. Anyway, applying this pa tch. - ARnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel