From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A67C433F5 for ; Sun, 10 Apr 2022 15:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238220AbiDJPW5 (ORCPT ); Sun, 10 Apr 2022 11:22:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiDJPW4 (ORCPT ); Sun, 10 Apr 2022 11:22:56 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BA759FD03 for ; Sun, 10 Apr 2022 08:20:45 -0700 (PDT) Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 7813563045; Sun, 10 Apr 2022 17:16:47 +0200 (CEST) Date: Sun, 10 Apr 2022 17:20:42 +0200 From: Pablo Neira Ayuso To: Martin Gignac Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] tests: py: Add meta time tests without 'meta' keyword Message-ID: References: <6251829e.xNu4VrF13GQsRBbt%martin.gignac@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6251829e.xNu4VrF13GQsRBbt%martin.gignac@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Sat, Apr 09, 2022 at 08:57:02AM -0400, Martin Gignac wrote: > v1.0.2 of 'nft' fails on 'time < "2022-07-01 11:00:00"' but succeeds > when 'meta' is specified ('meta time < "2022-07-01 11:00:00"'). This > extends coverage by testing 'time' without 'meta'. Applied, thanks. I extended it to cover the json codebase too (./nft-test -j).