From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214A0C433F5 for ; Mon, 11 Apr 2022 07:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244947AbiDKHT2 (ORCPT ); Mon, 11 Apr 2022 03:19:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242735AbiDKHT1 (ORCPT ); Mon, 11 Apr 2022 03:19:27 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5271321260; Mon, 11 Apr 2022 00:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5hihIePquetd4aWy3suo+aDqVPEvM45LHw98QVseVOA=; b=kXva0I5Hl4bc7vM3Sd99eZmDic 2+SUbsJm1znky37gaD/KD9LJRBfkdLJ0uOabAsnZ4CpPESO/sQ7jrbR4Fl6YJXC+dLuLwek6iU8j4 2tUMbaoaizmVJZi1nsJrWd75I6kroOznRW+jQP+6mn2LNGKlwmAhyYK5lKa5OyxJtldPFyxuwC9Ep 42Wxl0Ot+KpfHPNpfYPLEdj8CUF8TWc+G1MtEAbCFaujXsa29jU59X0fMkhYp0kUzPd9ucj1tCIfv aPi5UvAvCxSqPSDKv53Ok03FC+MnuxNh3sD9Nx/rR523y/41+mPoop/Zzk08qFreLAMxQ3G2Sdarz /UsPW6RQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58200) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ndoIH-0008VM-Qa; Mon, 11 Apr 2022 08:17:01 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ndoIF-0001E9-8a; Mon, 11 Apr 2022 08:16:59 +0100 Date: Mon, 11 Apr 2022 08:16:59 +0100 From: "Russell King (Oracle)" To: Vinod Koul Cc: Kevin Groeneveld , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Lucas Stach , Robin Gong , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: imx-sdma: fix regression with uart scripts Message-ID: References: <20220406224809.29197-1-kgroeneveld@lenbrook.com> <3b26a4e2-93a8-8b3f-20c3-c1593ea0d48b@lenbrook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Mon, Apr 11, 2022 at 11:29:23AM +0530, Vinod Koul wrote: > Hi Kevin, > > On 10-04-22, 18:28, Kevin Groeneveld wrote: > > On 2022-04-08 13:39, Vinod Koul wrote: > > > 1. Patch title should reflect the change introduced, so the title is not > > > apt, pls revise > > > > In hindsight the title was not very descriptive. I will update and send a > > v2. Maybe something like: > > > > dmaengine: imx-sdma: fix init of uart scripts > > > > > 2. Is this in response to rmk's report, if so, please add reported-by > > > > No. I am not even aware of any report on this issue. I discovered the issue > > on my own and found the problem commit by doing a bisect. > > Okay I am adding Russell here to see if this fixes his issue as well.. I "fixed" my issue by updating my SDMA firmware to the later version, which I think is fine provided I don't down-grade the kernel. That said, I do support this attempt to fix NXP's cockup, so, having looked at the patch: Acked-by: Russell King (Oracle) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F767C433F5 for ; Mon, 11 Apr 2022 07:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=biEywJbgxbwYuzkvCm723TKLZE0Ou7ES0EyyI5frGyg=; b=kW/L/OXvWf7saG R2zHNlku9KmMos7IaXEHAehUfcaM6seyCd/YdbiZD1lWB+1hZm2+edlOhCxqrMo3Vu1bcPDlrkUz3 FtwKHbXqt1lqgtvBGXtuojoXQNfGoo4MDzYMi/fYHjJoUsZk5VVsPl4yQgMgiUEMPfpDNoz2uhlS7 4BFuYufgE4Yb5+W2A6GsbjzdfrwfjckZQU+39OFtJqP0WPiKANR8IcS3J6af7tpvCZQVcF3xFYo7N HN3oMqidSwZT8qHINVfYCM/e70qBkMLGBnZQCzl+d/QWZK0vPjO7KGTE+v+DLZDB0MBDkOVCQTxoe fwDG+WGan8pzyMhWitdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndoIc-0078xb-3e; Mon, 11 Apr 2022 07:17:22 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndoIX-0078vy-PK for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 07:17:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5hihIePquetd4aWy3suo+aDqVPEvM45LHw98QVseVOA=; b=kXva0I5Hl4bc7vM3Sd99eZmDic 2+SUbsJm1znky37gaD/KD9LJRBfkdLJ0uOabAsnZ4CpPESO/sQ7jrbR4Fl6YJXC+dLuLwek6iU8j4 2tUMbaoaizmVJZi1nsJrWd75I6kroOznRW+jQP+6mn2LNGKlwmAhyYK5lKa5OyxJtldPFyxuwC9Ep 42Wxl0Ot+KpfHPNpfYPLEdj8CUF8TWc+G1MtEAbCFaujXsa29jU59X0fMkhYp0kUzPd9ucj1tCIfv aPi5UvAvCxSqPSDKv53Ok03FC+MnuxNh3sD9Nx/rR523y/41+mPoop/Zzk08qFreLAMxQ3G2Sdarz /UsPW6RQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58200) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ndoIH-0008VM-Qa; Mon, 11 Apr 2022 08:17:01 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ndoIF-0001E9-8a; Mon, 11 Apr 2022 08:16:59 +0100 Date: Mon, 11 Apr 2022 08:16:59 +0100 From: "Russell King (Oracle)" To: Vinod Koul Cc: Kevin Groeneveld , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Lucas Stach , Robin Gong , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: imx-sdma: fix regression with uart scripts Message-ID: References: <20220406224809.29197-1-kgroeneveld@lenbrook.com> <3b26a4e2-93a8-8b3f-20c3-c1593ea0d48b@lenbrook.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_001718_134270_88272A45 X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 11, 2022 at 11:29:23AM +0530, Vinod Koul wrote: > Hi Kevin, > > On 10-04-22, 18:28, Kevin Groeneveld wrote: > > On 2022-04-08 13:39, Vinod Koul wrote: > > > 1. Patch title should reflect the change introduced, so the title is not > > > apt, pls revise > > > > In hindsight the title was not very descriptive. I will update and send a > > v2. Maybe something like: > > > > dmaengine: imx-sdma: fix init of uart scripts > > > > > 2. Is this in response to rmk's report, if so, please add reported-by > > > > No. I am not even aware of any report on this issue. I discovered the issue > > on my own and found the problem commit by doing a bisect. > > Okay I am adding Russell here to see if this fixes his issue as well.. I "fixed" my issue by updating my SDMA firmware to the later version, which I think is fine provided I don't down-grade the kernel. That said, I do support this attempt to fix NXP's cockup, so, having looked at the patch: Acked-by: Russell King (Oracle) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel