From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Mon, 11 Apr 2022 13:22:58 +0300 Subject: [PATCH] usb: gadget: udc: clean up comments In-Reply-To: <20220410150828.1891123-1-trix@redhat.com> References: <20220410150828.1891123-1-trix@redhat.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, Apr 10, 2022 at 11:08:28AM -0400, Tom Rix wrote: > SPDX > *.h use /* */ style comments > > For double words, remove > with, also > > Spelling replacements > wayt to way > wakup to wakeup > Contrl to Control > cheks to checks > initiaization to initialization > dyanmic to dynamic Something really wrong with indentation above. ... > drivers/usb/gadget/udc/amd5536udc.h | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- > drivers/usb/gadget/udc/at91_udc.c | 2 +- > drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- > drivers/usb/gadget/udc/core.c | 4 ++-- > drivers/usb/gadget/udc/trace.h | 2 +- I believe that Greg's bot asks to split on per-driver basis. OTOH I don't see anything that can be problematic if in one change. So, it's up to maintainers then. ... > --- a/drivers/usb/gadget/udc/amd5536udc.h > +++ b/drivers/usb/gadget/udc/amd5536udc.h > * amd5536.h -- header for AMD 5536 UDC high/full speed USB device controller At the same time you may drop the filename(s) from the file(s) as this very one shows why it's good not to have a filename inside file. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB40C433EF for ; Mon, 11 Apr 2022 10:26:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345444AbiDKK3C (ORCPT ); Mon, 11 Apr 2022 06:29:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345438AbiDKK3A (ORCPT ); Mon, 11 Apr 2022 06:29:00 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 336473DDEB; Mon, 11 Apr 2022 03:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649672807; x=1681208807; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=w/B9OC3B9ubhCDDuz61ASu2Hiu/rM8Lrj6qHHNYq32U=; b=PEkdTgVIBKpikfPJb9nnVxnlA7BOopgtITPDU0Q2kruQ2xYupDh9yJQ6 qfP5fAyJwj3rYVAByYgqb7SUqe9BwckDUuSwI/Dqvyv17zU4iY1KOx3I0 Vm5eRey3DGlFnO4zf9RWCvGEyIekG+YMytSUVy5ckG/QnBXCUWjA76yB6 U4uN9DJSM8vn3vXJrjDT9slo6xRKaVfktAoTPsgzMHBzEeljNLVcjIIiz 8rtG/5hweZad0kRBqP5wBm4MgZlSe1DXFDEu4PC+ZzxwNy28x7pnLmZyv 77d5ytlLVp2y4KJJaFSOjRmPtIM/wakOiehx+X3kYmepRGuvFcWmh139E A==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="348521541" X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="348521541" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 03:26:46 -0700 X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="644032222" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 03:26:40 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1ndrCE-001BAf-W7; Mon, 11 Apr 2022 13:22:58 +0300 Date: Mon, 11 Apr 2022 13:22:58 +0300 From: Andy Shevchenko To: Tom Rix Cc: balbi@kernel.org, gregkh@linuxfoundation.org, joel@jms.id.au, andrew@aj.id.au, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, alcooperx@gmail.com, christophe.jaillet@wanadoo.fr, cai.huoqing@linux.dev, benh@kernel.crashing.org, neal_liu@aspeedtech.com, miles.chen@mediatek.com, balamanikandan.gunasundar@microchip.com, macpaul.lin@mediatek.com, s.shtylyov@omp.ru, jakobkoschel@gmail.com, stern@rowland.harvard.edu, quic_wcheng@quicinc.com, yashsri421@gmail.com, rdunlap@infradead.org, linux-geode@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH] usb: gadget: udc: clean up comments Message-ID: References: <20220410150828.1891123-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220410150828.1891123-1-trix@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sun, Apr 10, 2022 at 11:08:28AM -0400, Tom Rix wrote: > SPDX > *.h use /* */ style comments > > For double words, remove > with, also > > Spelling replacements > wayt to way > wakup to wakeup > Contrl to Control > cheks to checks > initiaization to initialization > dyanmic to dynamic Something really wrong with indentation above. ... > drivers/usb/gadget/udc/amd5536udc.h | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- > drivers/usb/gadget/udc/at91_udc.c | 2 +- > drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- > drivers/usb/gadget/udc/core.c | 4 ++-- > drivers/usb/gadget/udc/trace.h | 2 +- I believe that Greg's bot asks to split on per-driver basis. OTOH I don't see anything that can be problematic if in one change. So, it's up to maintainers then. ... > --- a/drivers/usb/gadget/udc/amd5536udc.h > +++ b/drivers/usb/gadget/udc/amd5536udc.h > * amd5536.h -- header for AMD 5536 UDC high/full speed USB device controller At the same time you may drop the filename(s) from the file(s) as this very one shows why it's good not to have a filename inside file. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7309FC433EF for ; Mon, 11 Apr 2022 10:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2b8RdNiSpRbS/cCOSwxFVwoGFD+f3vRuLGfnxesFcjg=; b=Hqpy8kifg8TLEr bFrZTAqpM8IggU7uwO6nm193pBmQq5iH6x8TUpGoC6M0u38k3tmWVy2NP3CH8dSmL6i8BKlo10rw8 ueat9XYF2WYpJIXHXvpKx9BIjcQWEM8U5YDO0+QNYDxaomUNyddu3l4vm8Eluuh6/tJrLbeEbWpsh NeqP4Pb3TqqYf1ldmEN4xb1Bag6la2/C3cpnq1ImX3SlHDPgkgthugMRqLbA6v79Lwo0U812tY4Lh B87LE5a2KHOeib6b6qgx9BVPJY0XjDZiOsiWMGoX9rd2z4Af33Ca35xh7PGBHST3UK4frCLK3fQo/ OTTJcpHAt6YR5iICI2og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndrRF-008PQg-MR; Mon, 11 Apr 2022 10:38:29 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndrFx-008Jfm-BQ; Mon, 11 Apr 2022 10:26:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649672809; x=1681208809; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=w/B9OC3B9ubhCDDuz61ASu2Hiu/rM8Lrj6qHHNYq32U=; b=OKRE3JFroAvvl+mWhTD7/KjDi59RfRATqj7n+IuXy7iusXnYqirfos9Y QmQRbPpJNXVpGbIXYucFglIyFLALkW/oIm5eyqDh9GDmzZGm44TDo4Xp1 9p6Cv4nLPcKDU/tkyD6NvCxtOpZHw49skC3HF8OE77LfLstNXbX0rQbJr pQ7p+YpII0Ra+PQQf281Uy3lV0UVmiiNsU2ZjMEaoWDYVDgluJsCh6ak7 hTcn8NaIY7ovKPQCkmFx+w5LjaH478dAAuSxTJw9LT6vOpYAMRKRekHro M/67MABfqEZppnl/7p0KGcLDvWEDy+8PeD4OanV1xC0JgQs4mf/3ZzJgh A==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="262262858" X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="262262858" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 03:26:46 -0700 X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="644032222" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 03:26:40 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1ndrCE-001BAf-W7; Mon, 11 Apr 2022 13:22:58 +0300 Date: Mon, 11 Apr 2022 13:22:58 +0300 From: Andy Shevchenko To: Tom Rix Subject: Re: [PATCH] usb: gadget: udc: clean up comments Message-ID: References: <20220410150828.1891123-1-trix@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220410150828.1891123-1-trix@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_032649_489997_96F9AAAB X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-usb@vger.kernel.org, linux-aspeed@lists.ozlabs.org, benh@kernel.crashing.org, alcooperx@gmail.com, linux-kernel@vger.kernel.org, macpaul.lin@mediatek.com, yashsri421@gmail.com, balamanikandan.gunasundar@microchip.com, stern@rowland.harvard.edu, joel@jms.id.au, bcm-kernel-feedback-list@broadcom.com, linux-geode@lists.infradead.org, christophe.jaillet@wanadoo.fr, jakobkoschel@gmail.com, linux-arm-kernel@lists.infradead.org, balbi@kernel.org, s.shtylyov@omp.ru, andrew@aj.id.au, neal_liu@aspeedtech.com, rdunlap@infradead.org, quic_wcheng@quicinc.com, miles.chen@mediatek.com, gregkh@linuxfoundation.org, cai.huoqing@linux.dev, claudiu.beznea@microchip.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 10, 2022 at 11:08:28AM -0400, Tom Rix wrote: > SPDX > *.h use /* */ style comments > > For double words, remove > with, also > > Spelling replacements > wayt to way > wakup to wakeup > Contrl to Control > cheks to checks > initiaization to initialization > dyanmic to dynamic Something really wrong with indentation above. ... > drivers/usb/gadget/udc/amd5536udc.h | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- > drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- > drivers/usb/gadget/udc/at91_udc.c | 2 +- > drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- > drivers/usb/gadget/udc/core.c | 4 ++-- > drivers/usb/gadget/udc/trace.h | 2 +- I believe that Greg's bot asks to split on per-driver basis. OTOH I don't see anything that can be problematic if in one change. So, it's up to maintainers then. ... > --- a/drivers/usb/gadget/udc/amd5536udc.h > +++ b/drivers/usb/gadget/udc/amd5536udc.h > * amd5536.h -- header for AMD 5536 UDC high/full speed USB device controller At the same time you may drop the filename(s) from the file(s) as this very one shows why it's good not to have a filename inside file. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel