From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Mon, 11 Apr 2022 14:24:48 +0200 Subject: [PATCH] usb: gadget: udc: clean up comments In-Reply-To: References: <20220410150828.1891123-1-trix@redhat.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Apr 11, 2022 at 04:49:00AM -0700, Tom Rix wrote: > > On 4/11/22 3:22 AM, Andy Shevchenko wrote: > > On Sun, Apr 10, 2022 at 11:08:28AM -0400, Tom Rix wrote: > > > SPDX > > > *.h use /* */ style comments > > > > > > For double words, remove > > > with, also > > > > > > Spelling replacements > > > wayt to way > > > wakup to wakeup > > > Contrl to Control > > > cheks to checks > > > initiaization to initialization > > > dyanmic to dynamic > > Something really wrong with indentation above. > > > > ... > > > > > drivers/usb/gadget/udc/amd5536udc.h | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- > > > drivers/usb/gadget/udc/at91_udc.c | 2 +- > > > drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- > > > drivers/usb/gadget/udc/core.c | 4 ++-- > > > drivers/usb/gadget/udc/trace.h | 2 +- > > I believe that Greg's bot asks to split on per-driver basis. > > OTOH I don't see anything that can be problematic if in one > > change. So, it's up to maintainers then. > > Yes, whatever folks want. I can split these. > > I have been cleaning up the comments in other areas and am trying to strike > a balance between too big of a patch vs peppering with many single changes. Patch series are much easier to review and is just as simple to apply as a single patch, so that makes it overall better for you to do. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A52C433EF for ; Mon, 11 Apr 2022 12:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232906AbiDKM1H (ORCPT ); Mon, 11 Apr 2022 08:27:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230080AbiDKM1G (ORCPT ); Mon, 11 Apr 2022 08:27:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B3B2DEDB; Mon, 11 Apr 2022 05:24:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E3D5261594; Mon, 11 Apr 2022 12:24:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFA0EC385A5; Mon, 11 Apr 2022 12:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649679891; bh=JWAqPgc7iD1EbdPyywpeDJppdn5+C50+xF16jAEfvEM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ss27V85LyEf3va8uUAhMU2T361UsxXasbR9zk5VhBFDgQKKAWrlxbo/ZIRwtKUMm1 oCaDGoCx0OavbahlsC7PhtGhwerIhAduzFShGEoJNTc2bbYtybz8c8H2rcn2mLoiKM r1MTB+/qp5OGpXLViaxgmnHTIekBgR5mBtYvxb3I= Date: Mon, 11 Apr 2022 14:24:48 +0200 From: Greg KH To: Tom Rix Cc: Andy Shevchenko , balbi@kernel.org, joel@jms.id.au, andrew@aj.id.au, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, alcooperx@gmail.com, christophe.jaillet@wanadoo.fr, cai.huoqing@linux.dev, benh@kernel.crashing.org, neal_liu@aspeedtech.com, miles.chen@mediatek.com, balamanikandan.gunasundar@microchip.com, macpaul.lin@mediatek.com, s.shtylyov@omp.ru, jakobkoschel@gmail.com, stern@rowland.harvard.edu, quic_wcheng@quicinc.com, yashsri421@gmail.com, rdunlap@infradead.org, linux-geode@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH] usb: gadget: udc: clean up comments Message-ID: References: <20220410150828.1891123-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Apr 11, 2022 at 04:49:00AM -0700, Tom Rix wrote: > > On 4/11/22 3:22 AM, Andy Shevchenko wrote: > > On Sun, Apr 10, 2022 at 11:08:28AM -0400, Tom Rix wrote: > > > SPDX > > > *.h use /* */ style comments > > > > > > For double words, remove > > > with, also > > > > > > Spelling replacements > > > wayt to way > > > wakup to wakeup > > > Contrl to Control > > > cheks to checks > > > initiaization to initialization > > > dyanmic to dynamic > > Something really wrong with indentation above. > > > > ... > > > > > drivers/usb/gadget/udc/amd5536udc.h | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- > > > drivers/usb/gadget/udc/at91_udc.c | 2 +- > > > drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- > > > drivers/usb/gadget/udc/core.c | 4 ++-- > > > drivers/usb/gadget/udc/trace.h | 2 +- > > I believe that Greg's bot asks to split on per-driver basis. > > OTOH I don't see anything that can be problematic if in one > > change. So, it's up to maintainers then. > > Yes, whatever folks want. I can split these. > > I have been cleaning up the comments in other areas and am trying to strike > a balance between too big of a patch vs peppering with many single changes. Patch series are much easier to review and is just as simple to apply as a single patch, so that makes it overall better for you to do. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC494C433F5 for ; Mon, 11 Apr 2022 12:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X98t1wsCvcbDk3TcGxHJl/luhFV6T140PwmFAvQ5cyk=; b=5B13vmKUNrC9LE U71bnrXbNOwiOW9We+jARpfuD17iCoAfN7BhlIVZbnCNZ61geIFR+cISEs4FNDlTC7MjlrBuEsaAG itV3q26eBU6tqL4Y43xjKXqEpaR7O/cU2UoPX4if5SUrVj94+r/fwzjxVFpz+fISigG0Kf2cjVLS6 4L1Had193+luHSuULKOVqzC8lWtIOrhFrpzLMf7xwWCUUmgaSDjz1Mh/wxNAnSGnrJy4FdpF9i2Pf OZxvi65+bF58cFh0YFLol6v7nMH0BsyjjaaKOTGNiQ9Qvs9CD8y/4xLQ1zcC0bK1bES123IEML9wl Oq4d5FSS+ZU2kt1aDdBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndt6H-008y4H-IK; Mon, 11 Apr 2022 12:24:57 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndt6E-008y32-Bw; Mon, 11 Apr 2022 12:24:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AB91BB81212; Mon, 11 Apr 2022 12:24:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFA0EC385A5; Mon, 11 Apr 2022 12:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649679891; bh=JWAqPgc7iD1EbdPyywpeDJppdn5+C50+xF16jAEfvEM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ss27V85LyEf3va8uUAhMU2T361UsxXasbR9zk5VhBFDgQKKAWrlxbo/ZIRwtKUMm1 oCaDGoCx0OavbahlsC7PhtGhwerIhAduzFShGEoJNTc2bbYtybz8c8H2rcn2mLoiKM r1MTB+/qp5OGpXLViaxgmnHTIekBgR5mBtYvxb3I= Date: Mon, 11 Apr 2022 14:24:48 +0200 From: Greg KH To: Tom Rix Subject: Re: [PATCH] usb: gadget: udc: clean up comments Message-ID: References: <20220410150828.1891123-1-trix@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_052454_577677_8C5D5BFF X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-usb@vger.kernel.org, linux-aspeed@lists.ozlabs.org, benh@kernel.crashing.org, alcooperx@gmail.com, linux-kernel@vger.kernel.org, macpaul.lin@mediatek.com, yashsri421@gmail.com, balamanikandan.gunasundar@microchip.com, stern@rowland.harvard.edu, joel@jms.id.au, bcm-kernel-feedback-list@broadcom.com, linux-geode@lists.infradead.org, christophe.jaillet@wanadoo.fr, jakobkoschel@gmail.com, Andy Shevchenko , linux-arm-kernel@lists.infradead.org, balbi@kernel.org, s.shtylyov@omp.ru, andrew@aj.id.au, neal_liu@aspeedtech.com, rdunlap@infradead.org, quic_wcheng@quicinc.com, miles.chen@mediatek.com, cai.huoqing@linux.dev, claudiu.beznea@microchip.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 11, 2022 at 04:49:00AM -0700, Tom Rix wrote: > > On 4/11/22 3:22 AM, Andy Shevchenko wrote: > > On Sun, Apr 10, 2022 at 11:08:28AM -0400, Tom Rix wrote: > > > SPDX > > > *.h use /* */ style comments > > > > > > For double words, remove > > > with, also > > > > > > Spelling replacements > > > wayt to way > > > wakup to wakeup > > > Contrl to Control > > > cheks to checks > > > initiaization to initialization > > > dyanmic to dynamic > > Something really wrong with indentation above. > > > > ... > > > > > drivers/usb/gadget/udc/amd5536udc.h | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +- > > > drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++-- > > > drivers/usb/gadget/udc/at91_udc.c | 2 +- > > > drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++-- > > > drivers/usb/gadget/udc/core.c | 4 ++-- > > > drivers/usb/gadget/udc/trace.h | 2 +- > > I believe that Greg's bot asks to split on per-driver basis. > > OTOH I don't see anything that can be problematic if in one > > change. So, it's up to maintainers then. > > Yes, whatever folks want. I can split these. > > I have been cleaning up the comments in other areas and am trying to strike > a balance between too big of a patch vs peppering with many single changes. Patch series are much easier to review and is just as simple to apply as a single patch, so that makes it overall better for you to do. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel