From: Eric Biggers <ebiggers@kernel.org>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
qat-linux@intel.com, stable@vger.kernel.org,
Mikulas Patocka <mpatocka@redhat.com>,
Marco Chiappero <marco.chiappero@intel.com>,
Wojciech Ziemba <wojciech.ziemba@intel.com>
Subject: Re: [PATCH v3 1/3] crypto: qat - use pre-allocated buffers in datapath
Date: Mon, 11 Apr 2022 17:37:24 +0000 [thread overview]
Message-ID: <YlRnVBYl1eJ+zvM5@gmail.com> (raw)
In-Reply-To: <20220410194707.9746-2-giovanni.cabiddu@intel.com>
On Sun, Apr 10, 2022 at 08:47:05PM +0100, Giovanni Cabiddu wrote:
> If requests exceed 4 entries buffers, memory is allocated dynamically.
>
> In addition, remove the CRYPTO_ALG_ALLOCATES_MEMORY flag from both aead
> and skcipher alg structures.
>
There is nothing that says that algorithms can ignore
!CRYPTO_ALG_ALLOCATES_MEMORY if there are too many scatterlist entries. See the
comment above the definition of CRYPTO_ALG_ALLOCATES_MEMORY.
If you need to introduce this constraint, then you will need to audit the users
of !CRYPTO_ALG_ALLOCATES_MEMORY to verify that none of them are issuing requests
that violate this constraint, then add this to the documentation comment for
CRYPTO_ALG_ALLOCATES_MEMORY.
- Eric
next prev parent reply other threads:[~2022-04-11 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 19:47 [PATCH v3 0/3] crypto: qat - fix dm-crypt related issues Giovanni Cabiddu
2022-04-10 19:47 ` [PATCH v3 1/3] crypto: qat - use pre-allocated buffers in datapath Giovanni Cabiddu
2022-04-11 17:37 ` Eric Biggers [this message]
2022-04-19 10:31 ` [dm-devel] " Giovanni Cabiddu
2022-04-19 10:31 ` Giovanni Cabiddu
2022-07-11 14:21 ` Giovanni Cabiddu
2022-07-11 15:09 ` [dm-devel] " Lucas Segarra
2022-07-11 15:09 ` Lucas Segarra
2022-04-10 19:47 ` [PATCH v3 2/3] crypto: qat - refactor submission logic Giovanni Cabiddu
2022-04-10 19:47 ` [PATCH v3 3/3] crypto: qat - add backlog mechanism Giovanni Cabiddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlRnVBYl1eJ+zvM5@gmail.com \
--to=ebiggers@kernel.org \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=marco.chiappero@intel.com \
--cc=mpatocka@redhat.com \
--cc=qat-linux@intel.com \
--cc=stable@vger.kernel.org \
--cc=wojciech.ziemba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.