From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EE41C433FE for ; Tue, 12 Apr 2022 10:13:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234044AbiDLKPN (ORCPT ); Tue, 12 Apr 2022 06:15:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354423AbiDLKDY (ORCPT ); Tue, 12 Apr 2022 06:03:24 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B6F69255A0; Tue, 12 Apr 2022 02:10:42 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 688D98061; Tue, 12 Apr 2022 09:08:09 +0000 (UTC) Date: Tue, 12 Apr 2022 12:10:40 +0300 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Daniel Lezcano , Keerthy , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml Message-ID: References: <20220411111858.16814-1-tony@atomide.com> <3f3ec103-a7d8-b56d-afff-94a0379dffec@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f3ec103-a7d8-b56d-afff-94a0379dffec@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, * Krzysztof Kozlowski [220412 08:58]: > On 11/04/2022 13:18, Tony Lindgren wrote: > > Some timers on some SoCs are dual mapped, like the ABE timers on omap4 > > and 5. The reg property maxItems must be updated to 2. So on omap4/5 there are timers with a single IO register and with dual mapped IO registers. > (...) > > > + reg: > > + minItems: 1 > > + maxItems: 2 > > + description: Timer IO register range > > + > > Apart from what Grygorii said, it would be useful if you add "if:then:" > case constraining it per implementation (as I understood from commit msg > only some use double mapping). > > This looks like: > https://elixir.bootlin.com/linux/v5.18-rc2/source/Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml#L53 Yes I tried, but see the above. The compatible property is the same for single mapped and dual mapped timers on the same SoC for omap4/5. > Similarly should be done for clocks, unless it's impossible (same > compatible uses different setups of clocks). It's the same situation for clocks, the same compatible is used for timers with one clock and timers with two clocks for example on dra7. I'll check the description again to clarify this, maybe it's not clear yet. > BTW, it's a bit confusing it is not a v2... Oops sorry looks like I forgot to update the version. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9450EC433EF for ; Tue, 12 Apr 2022 09:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aJQI2RREZOkRC5sEwOFGVYzBjnJ+gzhMQyrZi8DtMTw=; b=Yfeg46pBhVKs+v CEqCVGFI/WUz5xloEiU94ANQ93fryybehqcqAyosv5tU72sexq9wfpUgpUAB53XV81aZnyJq4oSxn cYa6y+LT9BmsO17fIslfw/nteH6TXDBUY007dTu0zC7d2dSwGi2Etj1pciIZJ7Z+bQjyqJ3lYx3x1 x7KAPXkcNAbm4/YEeDbz1pZhir9+ORXL7ZvhYr4dK1hMpYO5ycer8lRmwQZu/k1Db05AQF8CMHcXG Y3+KW4ZX2VLTtCb1yxf8aWiBXcmsolxOI3+tN3uCL0ohfXpDAzzBqaAPlM5qvxO5g/9mNMS006gxc SkcRigd2URXiKoWzMcGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCXv-00CoGm-K3; Tue, 12 Apr 2022 09:10:47 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neCXr-00CoFU-5A for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 09:10:45 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 688D98061; Tue, 12 Apr 2022 09:08:09 +0000 (UTC) Date: Tue, 12 Apr 2022 12:10:40 +0300 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Daniel Lezcano , Keerthy , Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml Message-ID: References: <20220411111858.16814-1-tony@atomide.com> <3f3ec103-a7d8-b56d-afff-94a0379dffec@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3f3ec103-a7d8-b56d-afff-94a0379dffec@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_021043_298183_862C5DAF X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Krzysztof Kozlowski [220412 08:58]: > On 11/04/2022 13:18, Tony Lindgren wrote: > > Some timers on some SoCs are dual mapped, like the ABE timers on omap4 > > and 5. The reg property maxItems must be updated to 2. So on omap4/5 there are timers with a single IO register and with dual mapped IO registers. > (...) > > > + reg: > > + minItems: 1 > > + maxItems: 2 > > + description: Timer IO register range > > + > > Apart from what Grygorii said, it would be useful if you add "if:then:" > case constraining it per implementation (as I understood from commit msg > only some use double mapping). > > This looks like: > https://elixir.bootlin.com/linux/v5.18-rc2/source/Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml#L53 Yes I tried, but see the above. The compatible property is the same for single mapped and dual mapped timers on the same SoC for omap4/5. > Similarly should be done for clocks, unless it's impossible (same > compatible uses different setups of clocks). It's the same situation for clocks, the same compatible is used for timers with one clock and timers with two clocks for example on dra7. I'll check the description again to clarify this, maybe it's not clear yet. > BTW, it's a bit confusing it is not a v2... Oops sorry looks like I forgot to update the version. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel