From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B9B63D82 for ; Tue, 12 Apr 2022 21:09:01 +0000 (UTC) Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-d6ca46da48so18682fac.12 for ; Tue, 12 Apr 2022 14:09:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cJkmHfdBxf221GLO6Rp2mXWctk7aSf4CdfI04IRAEBI=; b=LzmqurT9xmVYyuKriqWuZyLrPkz69q40l+JDV3Khru9re0DgI0XTWFB5CcVQJYcnIu COkYqAgLX7zSBPptsoM4T21f7qc94dIXXJGFrF/aH8chOkiksL0e4+bB6vGd+4FmzVEj vivieOcCn/S8VomcwEu0HsERTCkIjS8E9IiKYMWLyxSYvKU+XBS3YH64EgMtTvYhhLqC X9PXrWR+kWymIY7ijydg2s8GWDuwUL4XwI2wyCNN2nHQ05fSDYZr8FEsQf4vFjKiKjNG ArzpQEHxYixbJBzxZxKfpJ17ucIY8K7ytglzn966//DkcM5P9ZMdj1LIYn2FD/euCBSd tvvg== X-Gm-Message-State: AOAM532cF6x4A33TyWpqJcKK4BynQlnxfGrD7OgIImN+PlIm+XGBcmUq 5Sq0UKZc2sSv6sIC+l/vUQ== X-Google-Smtp-Source: ABdhPJxzHVBv05OKxWV0sTv8Hm3nF460ieQSkUefeU8+7dcceq2HdX1Y1OEyRNmYiktpO+V5nGy4WA== X-Received: by 2002:a05:6870:4290:b0:e2:b4c9:ea5a with SMTP id y16-20020a056870429000b000e2b4c9ea5amr2900806oah.173.1649797740517; Tue, 12 Apr 2022 14:09:00 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d1-20020a056830138100b005cf2f29d89csm13533691otq.77.2022.04.12.14.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 14:09:00 -0700 (PDT) Received: (nullmailer pid 946357 invoked by uid 1000); Tue, 12 Apr 2022 21:08:59 -0000 Date: Tue, 12 Apr 2022 16:08:59 -0500 From: Rob Herring To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Maxime Ripard , Daniel Vetter , David Airlie , Krzysztof Kozlowski , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Krzysztof Kozlowski Subject: Re: [PATCH v2 02/14] dt-bindings: display: Add D1 display engine compatibles Message-ID: References: <20220412042807.47519-1-samuel@sholland.org> <20220412042807.47519-3-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220412042807.47519-3-samuel@sholland.org> On Mon, Apr 11, 2022 at 11:27:54PM -0500, Samuel Holland wrote: > Allwinner D1 contains a display engine 2.0. It features two mixers, a > TCON TOP (with DSI and HDMI), one TCON LCD, and one TCON TV. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Samuel Holland > --- > > (no changes since v1) > > .../allwinner,sun4i-a10-display-engine.yaml | 1 + > .../display/allwinner,sun4i-a10-tcon.yaml | 2 ++ > .../allwinner,sun8i-a83t-de2-mixer.yaml | 2 ++ > .../display/allwinner,sun8i-r40-tcon-top.yaml | 34 +++++++++++++++++++ > 4 files changed, 39 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > index d4412aea7b73..c388ae5da1e4 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > @@ -62,6 +62,7 @@ properties: > - allwinner,sun8i-r40-display-engine > - allwinner,sun8i-v3s-display-engine > - allwinner,sun9i-a80-display-engine > + - allwinner,sun20i-d1-display-engine > - allwinner,sun50i-a64-display-engine > - allwinner,sun50i-h6-display-engine > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > index 3a7d5d731712..4a92a4c7dcd7 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > @@ -33,6 +33,8 @@ properties: > - const: allwinner,sun8i-v3s-tcon > - const: allwinner,sun9i-a80-tcon-lcd > - const: allwinner,sun9i-a80-tcon-tv > + - const: allwinner,sun20i-d1-tcon-lcd > + - const: allwinner,sun20i-d1-tcon-tv > > - items: > - enum: > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > index 4f91eec26de9..cb243bc58ef7 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > @@ -19,6 +19,8 @@ properties: > - allwinner,sun8i-r40-de2-mixer-0 > - allwinner,sun8i-r40-de2-mixer-1 > - allwinner,sun8i-v3s-de2-mixer > + - allwinner,sun20i-d1-de2-mixer-0 > + - allwinner,sun20i-d1-de2-mixer-1 > - allwinner,sun50i-a64-de2-mixer-0 > - allwinner,sun50i-a64-de2-mixer-1 > - allwinner,sun50i-h6-de3-mixer-0 > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > index 784b267635fb..cc32e2faed91 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > @@ -41,6 +41,7 @@ properties: > compatible: > enum: > - allwinner,sun8i-r40-tcon-top > + - allwinner,sun20i-d1-tcon-top > - allwinner,sun50i-h6-tcon-top > > reg: > @@ -154,6 +155,39 @@ allOf: > - port@2 > - port@3 > > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun20i-d1-tcon-top > + > + then: > + properties: > + clocks: > + minItems: 4 > + maxItems: 4 You shouldn't need minItems and maxItems here and the next 2 cases. > + items: > + - description: The TCON TOP interface clock > + - description: The TCON TOP TV0 clock > + - description: The TCON TOP TVE0 clock > + - description: The TCON TOP MIPI DSI clock > + > + clock-names: > + minItems: 4 > + maxItems: 4 > + items: > + - const: bus > + - const: tcon-tv0 > + - const: tve0 > + - const: dsi > + > + clock-output-names: > + minItems: 2 > + maxItems: 2 > + items: > + - description: TCON TV0 output clock name > + - description: DSI output clock name > + > - if: > properties: > compatible: > -- > 2.35.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6AC2C433EF for ; Tue, 12 Apr 2022 21:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hEhwZpMmzgwuPdfu4u+4UNH21lHC9dFx7by/uSBoBEs=; b=krnNIQkTRNPrPo HhBYoG8rn4oQobywN8D59rPVDnf0drWCK7d+ntKQV7wDsAGgfWdi8A7ZvGir9DugunC0YwKlfjs5M BFk18rFthFQ7lhy6WivnH3YuH7KBTGF4Qh+7QaTvyGmFQTJxoGdgxVYwfS7MrcOan4uM8mzZoaj8j YRAmEGB6adorwf+XmbimyxXsFO/k46GuLhK+Bl6SL1izq55DofFWp3RrqSdWd819iKr7ct6hcrkJ2 ra0nEYlVqPRwQJ8U6cUmabVkImCKM/Nk7YAgcPANwlMHRcYtmGVPIJL/gjMmZy3F+VDSwwZgL2yLu pxwpCPeoJRP9TRA/D/Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neNl4-00Fmmt-FC; Tue, 12 Apr 2022 21:09:06 +0000 Received: from mail-oa1-f44.google.com ([209.85.160.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neNl1-00Fmm5-3d for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 21:09:04 +0000 Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-ddfa38f1c1so24013fac.11 for ; Tue, 12 Apr 2022 14:09:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cJkmHfdBxf221GLO6Rp2mXWctk7aSf4CdfI04IRAEBI=; b=bVVOgMoMAqSxMHxc4957NX1Xgh3+aTeAFRTLvCvHFLoalq5srvC5DDGjQrxZwV6WPF m+0p1Oru9UbHUpnh9li3IusoGznu0wHOWb5F24/2I3d+c2CvVko+7x915Tl4jbz8M6rX l+BaRfbDn6WEMHVwp8QiIEUvAAPRXT2nuLfYfn9raBATUeqhDmTGLzlpLK/SI6aCuEIv B8hv4dKsNKyU2HoLq9R0EO3XmmUimVCDLm8pvNvJnBeczDnNJd8IIo7rk9ClBLwC4sr0 ueoJJ1EWQwELSnmfkP0iezzsQhgS45eh17z90xW6XWxtaqLPk84vkRLP+jdyI1XF+VDv WVLA== X-Gm-Message-State: AOAM5326uUCLGWAhPB29YFO5pYthFwmjDjt/eXIAy0XcT8e5nlvzmG8A GNAvK5pdDioQ9R4QYsRsTg== X-Google-Smtp-Source: ABdhPJxzHVBv05OKxWV0sTv8Hm3nF460ieQSkUefeU8+7dcceq2HdX1Y1OEyRNmYiktpO+V5nGy4WA== X-Received: by 2002:a05:6870:4290:b0:e2:b4c9:ea5a with SMTP id y16-20020a056870429000b000e2b4c9ea5amr2900806oah.173.1649797740517; Tue, 12 Apr 2022 14:09:00 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d1-20020a056830138100b005cf2f29d89csm13533691otq.77.2022.04.12.14.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 14:09:00 -0700 (PDT) Received: (nullmailer pid 946357 invoked by uid 1000); Tue, 12 Apr 2022 21:08:59 -0000 Date: Tue, 12 Apr 2022 16:08:59 -0500 From: Rob Herring To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Maxime Ripard , Daniel Vetter , David Airlie , Krzysztof Kozlowski , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Krzysztof Kozlowski Subject: Re: [PATCH v2 02/14] dt-bindings: display: Add D1 display engine compatibles Message-ID: References: <20220412042807.47519-1-samuel@sholland.org> <20220412042807.47519-3-samuel@sholland.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220412042807.47519-3-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_140903_191873_E9BEEB47 X-CRM114-Status: GOOD ( 17.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 11, 2022 at 11:27:54PM -0500, Samuel Holland wrote: > Allwinner D1 contains a display engine 2.0. It features two mixers, a > TCON TOP (with DSI and HDMI), one TCON LCD, and one TCON TV. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Samuel Holland > --- > > (no changes since v1) > > .../allwinner,sun4i-a10-display-engine.yaml | 1 + > .../display/allwinner,sun4i-a10-tcon.yaml | 2 ++ > .../allwinner,sun8i-a83t-de2-mixer.yaml | 2 ++ > .../display/allwinner,sun8i-r40-tcon-top.yaml | 34 +++++++++++++++++++ > 4 files changed, 39 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > index d4412aea7b73..c388ae5da1e4 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > @@ -62,6 +62,7 @@ properties: > - allwinner,sun8i-r40-display-engine > - allwinner,sun8i-v3s-display-engine > - allwinner,sun9i-a80-display-engine > + - allwinner,sun20i-d1-display-engine > - allwinner,sun50i-a64-display-engine > - allwinner,sun50i-h6-display-engine > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > index 3a7d5d731712..4a92a4c7dcd7 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > @@ -33,6 +33,8 @@ properties: > - const: allwinner,sun8i-v3s-tcon > - const: allwinner,sun9i-a80-tcon-lcd > - const: allwinner,sun9i-a80-tcon-tv > + - const: allwinner,sun20i-d1-tcon-lcd > + - const: allwinner,sun20i-d1-tcon-tv > > - items: > - enum: > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > index 4f91eec26de9..cb243bc58ef7 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > @@ -19,6 +19,8 @@ properties: > - allwinner,sun8i-r40-de2-mixer-0 > - allwinner,sun8i-r40-de2-mixer-1 > - allwinner,sun8i-v3s-de2-mixer > + - allwinner,sun20i-d1-de2-mixer-0 > + - allwinner,sun20i-d1-de2-mixer-1 > - allwinner,sun50i-a64-de2-mixer-0 > - allwinner,sun50i-a64-de2-mixer-1 > - allwinner,sun50i-h6-de3-mixer-0 > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > index 784b267635fb..cc32e2faed91 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > @@ -41,6 +41,7 @@ properties: > compatible: > enum: > - allwinner,sun8i-r40-tcon-top > + - allwinner,sun20i-d1-tcon-top > - allwinner,sun50i-h6-tcon-top > > reg: > @@ -154,6 +155,39 @@ allOf: > - port@2 > - port@3 > > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun20i-d1-tcon-top > + > + then: > + properties: > + clocks: > + minItems: 4 > + maxItems: 4 You shouldn't need minItems and maxItems here and the next 2 cases. > + items: > + - description: The TCON TOP interface clock > + - description: The TCON TOP TV0 clock > + - description: The TCON TOP TVE0 clock > + - description: The TCON TOP MIPI DSI clock > + > + clock-names: > + minItems: 4 > + maxItems: 4 > + items: > + - const: bus > + - const: tcon-tv0 > + - const: tve0 > + - const: dsi > + > + clock-output-names: > + minItems: 2 > + maxItems: 2 > + items: > + - description: TCON TV0 output clock name > + - description: DSI output clock name > + > - if: > properties: > compatible: > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D52C4C433EF for ; Tue, 12 Apr 2022 21:09:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3A1710E66D; Tue, 12 Apr 2022 21:09:02 +0000 (UTC) Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B79010E66D for ; Tue, 12 Apr 2022 21:09:01 +0000 (UTC) Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-de3eda6b5dso99534fac.0 for ; Tue, 12 Apr 2022 14:09:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cJkmHfdBxf221GLO6Rp2mXWctk7aSf4CdfI04IRAEBI=; b=gn8DYY9lAjQOTiKUlVEI4M5jOklc7ln/5wdCJylwqsBzLGFmxg/aaFNe5/9CvU7T7W u8g4Txw37zGPDwA/u7oF9XaqbqJk416DSqD71jevGpU8yqm9LkbDYaPAnFKHn3S7KKNj Qs9KbmIpNoqpDwK8hwxwAy1fMYobGZf5baaeNSKz4furUuSX2SSjWaPMJEuIx/LhMKwd QD8Nh6DRXwLPXbV1BBfjzYBq8d4sW12O585tjzPqyuMxn3vp1blK1FxEo64zrCTiZbL8 2B8UvRb3wzsvFkHND9DHVJJflFleapOX4Un79oC0D1TrdcGfVw23Lf5mUGv5kYXcAPs0 fAaw== X-Gm-Message-State: AOAM530CqLsALbkKwmS8xxmNrxcosd951iwfoBy2QuVJ+V64GybJ3alm J5olA36P3b7jYbNGRP0mOw== X-Google-Smtp-Source: ABdhPJxzHVBv05OKxWV0sTv8Hm3nF460ieQSkUefeU8+7dcceq2HdX1Y1OEyRNmYiktpO+V5nGy4WA== X-Received: by 2002:a05:6870:4290:b0:e2:b4c9:ea5a with SMTP id y16-20020a056870429000b000e2b4c9ea5amr2900806oah.173.1649797740517; Tue, 12 Apr 2022 14:09:00 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d1-20020a056830138100b005cf2f29d89csm13533691otq.77.2022.04.12.14.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 14:09:00 -0700 (PDT) Received: (nullmailer pid 946357 invoked by uid 1000); Tue, 12 Apr 2022 21:08:59 -0000 Date: Tue, 12 Apr 2022 16:08:59 -0500 From: Rob Herring To: Samuel Holland Subject: Re: [PATCH v2 02/14] dt-bindings: display: Add D1 display engine compatibles Message-ID: References: <20220412042807.47519-1-samuel@sholland.org> <20220412042807.47519-3-samuel@sholland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220412042807.47519-3-samuel@sholland.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Apr 11, 2022 at 11:27:54PM -0500, Samuel Holland wrote: > Allwinner D1 contains a display engine 2.0. It features two mixers, a > TCON TOP (with DSI and HDMI), one TCON LCD, and one TCON TV. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Samuel Holland > --- > > (no changes since v1) > > .../allwinner,sun4i-a10-display-engine.yaml | 1 + > .../display/allwinner,sun4i-a10-tcon.yaml | 2 ++ > .../allwinner,sun8i-a83t-de2-mixer.yaml | 2 ++ > .../display/allwinner,sun8i-r40-tcon-top.yaml | 34 +++++++++++++++++++ > 4 files changed, 39 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > index d4412aea7b73..c388ae5da1e4 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > @@ -62,6 +62,7 @@ properties: > - allwinner,sun8i-r40-display-engine > - allwinner,sun8i-v3s-display-engine > - allwinner,sun9i-a80-display-engine > + - allwinner,sun20i-d1-display-engine > - allwinner,sun50i-a64-display-engine > - allwinner,sun50i-h6-display-engine > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > index 3a7d5d731712..4a92a4c7dcd7 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > @@ -33,6 +33,8 @@ properties: > - const: allwinner,sun8i-v3s-tcon > - const: allwinner,sun9i-a80-tcon-lcd > - const: allwinner,sun9i-a80-tcon-tv > + - const: allwinner,sun20i-d1-tcon-lcd > + - const: allwinner,sun20i-d1-tcon-tv > > - items: > - enum: > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > index 4f91eec26de9..cb243bc58ef7 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > @@ -19,6 +19,8 @@ properties: > - allwinner,sun8i-r40-de2-mixer-0 > - allwinner,sun8i-r40-de2-mixer-1 > - allwinner,sun8i-v3s-de2-mixer > + - allwinner,sun20i-d1-de2-mixer-0 > + - allwinner,sun20i-d1-de2-mixer-1 > - allwinner,sun50i-a64-de2-mixer-0 > - allwinner,sun50i-a64-de2-mixer-1 > - allwinner,sun50i-h6-de3-mixer-0 > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > index 784b267635fb..cc32e2faed91 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > @@ -41,6 +41,7 @@ properties: > compatible: > enum: > - allwinner,sun8i-r40-tcon-top > + - allwinner,sun20i-d1-tcon-top > - allwinner,sun50i-h6-tcon-top > > reg: > @@ -154,6 +155,39 @@ allOf: > - port@2 > - port@3 > > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun20i-d1-tcon-top > + > + then: > + properties: > + clocks: > + minItems: 4 > + maxItems: 4 You shouldn't need minItems and maxItems here and the next 2 cases. > + items: > + - description: The TCON TOP interface clock > + - description: The TCON TOP TV0 clock > + - description: The TCON TOP TVE0 clock > + - description: The TCON TOP MIPI DSI clock > + > + clock-names: > + minItems: 4 > + maxItems: 4 > + items: > + - const: bus > + - const: tcon-tv0 > + - const: tve0 > + - const: dsi > + > + clock-output-names: > + minItems: 2 > + maxItems: 2 > + items: > + - description: TCON TV0 output clock name > + - description: DSI output clock name > + > - if: > properties: > compatible: > -- > 2.35.1 > >