All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Tao Klerks <tao@klerks.biz>
Cc: rsbecker@nexbridge.com, "Michal Suchánek" <msuchanek@suse.de>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	jurgen_gjoncari@icloud.com, git@vger.kernel.org
Subject: Re: Make commit messages optional
Date: Tue, 12 Apr 2022 22:40:17 -0700	[thread overview]
Message-ID: <YlZiQemrAuryF0vv@google.com> (raw)
In-Reply-To: <CAPMMpohnwTTwTEjr9u29O_qVJtQNuG29G3Ta+-rXz-De8zvMCQ@mail.gmail.com>

Hi,

Tao Klerks wrote:
> On Sun, Apr 10, 2022 at 5:18 PM <rsbecker@nexbridge.com> wrote:

>> And I still don't get why the --allow-empty-message is not
>> sufficient to meet your use case. git supports what is being
>> requested already, not that it is allowed where I am. Are we
>> talking about setting --allow-empty-message as the default? That is
>> a major behavioural change. You could create a git command alias to
>> always specify this option. So what is the point of this?
>>
>
> My proposal is that it absolutely is enough, functionally - but the
> abundance of "we should change something" concerns in this thread and
> elsewhere suggest, to me, that it might not be sufficiently
> discoverable; hence the "advice" proposal.

Thanks for this point.  I find it to be a very reasonable one.  I'd be
happy to review a patch adding an advice item when people use options
like '-m ""'.

Sincerely,
Jonathan

  reply	other threads:[~2022-04-13  5:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  3:35 Make commit messages optional jurgen_gjoncari
2022-04-08  8:02 ` Christian Couder
2022-04-08 11:26   ` Ævar Arnfjörð Bjarmason
2022-04-08 19:25     ` Erik Cervin Edin
2022-04-11 10:24       ` Ævar Arnfjörð Bjarmason
2022-04-11 17:59         ` Junio C Hamano
2022-04-11 18:18           ` Michal Suchánek
2022-04-11 21:09             ` Junio C Hamano
2022-04-08  8:15 ` Philip Oakley
2022-04-08 14:32 ` Phillip Susi
2022-04-08 22:30 ` brian m. carlson
2022-04-08 23:32   ` rsbecker
2022-04-09 11:32     ` Michal Suchánek
2022-04-10 13:59       ` Tao Klerks
2022-04-10 15:00         ` rsbecker
2022-04-10 15:18           ` rsbecker
2022-04-10 16:27             ` Tao Klerks
2022-04-13  5:40               ` Jonathan Nieder [this message]
2022-04-11  9:04           ` demerphq
2022-04-11 11:35             ` rsbecker
2022-04-11 10:19         ` Ævar Arnfjörð Bjarmason
2022-04-11 12:39           ` Tao Klerks
2022-04-11 18:09             ` Junio C Hamano
2022-04-11 18:15               ` Michal Suchánek
2022-04-11 18:23           ` tytso
2022-04-11 20:10             ` Ævar Arnfjörð Bjarmason
2022-04-14 14:46               ` Theodore Ts'o
2022-04-14 16:43                 ` Ævar Arnfjörð Bjarmason
2022-04-14 17:25                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlZiQemrAuryF0vv@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jurgen_gjoncari@icloud.com \
    --cc=msuchanek@suse.de \
    --cc=rsbecker@nexbridge.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=tao@klerks.biz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.