From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: display: panel-timing: Define a single type for properties
Date: Wed, 13 Apr 2022 19:44:59 +0200 [thread overview]
Message-ID: <YlcMG0sxMG0AXb4y@ravnborg.org> (raw)
In-Reply-To: <20220413140016.3131013-1-robh@kernel.org>
Hi Rob,
On Wed, Apr 13, 2022 at 09:00:15AM -0500, Rob Herring wrote:
> It's not good practice to define multiple types for the same property, so
> factor out the type reference making the properties always an uint32-array
> with a length of 1 or 3 items.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Looks good,
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Let me know if we shall take it in drm-misc.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: display: panel-timing: Define a single type for properties
Date: Wed, 13 Apr 2022 19:44:59 +0200 [thread overview]
Message-ID: <YlcMG0sxMG0AXb4y@ravnborg.org> (raw)
In-Reply-To: <20220413140016.3131013-1-robh@kernel.org>
Hi Rob,
On Wed, Apr 13, 2022 at 09:00:15AM -0500, Rob Herring wrote:
> It's not good practice to define multiple types for the same property, so
> factor out the type reference making the properties always an uint32-array
> with a length of 1 or 3 items.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Looks good,
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Let me know if we shall take it in drm-misc.
Sam
next prev parent reply other threads:[~2022-04-13 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 14:00 [PATCH] dt-bindings: display: panel-timing: Define a single type for properties Rob Herring
2022-04-13 14:00 ` Rob Herring
2022-04-13 17:44 ` Sam Ravnborg [this message]
2022-04-13 17:44 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlcMG0sxMG0AXb4y@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.