From: Greg KH <gregkh@linuxfoundation.org>
To: Luca Coelho <luca@coelho.fi>
Cc: stable@vger.kernel.org, gregory.greenman@intel.com
Subject: Re: [PATCH 5.17] iwlwifi: yoyo: fix DBGI_SRAM ini dump header.
Date: Thu, 14 Apr 2022 12:59:48 +0200 [thread overview]
Message-ID: <Ylf+pLW54GU23JNS@kroah.com> (raw)
In-Reply-To: <20220413080600.281718-1-luca@coelho.fi>
On Wed, Apr 13, 2022 at 11:06:00AM +0300, Luca Coelho wrote:
> From: Rotem Saado <rotem.saado@intel.com>
>
> commit 34bc27783a31a05d2fb987d8fa0f4f702efd0359 upstream.
>
> DBGI SRAM is new type of monitor, therefore it should be
> dump as monitor type with ini dump monitor header.
>
> Signed-off-by: Rotem Saado <rotem.saado@intel.com>
> Fixes: 89639e06d0f3 ("iwlwifi: yoyo: support for new DBGI_SRAM region")
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> Link: https://lore.kernel.org/r/iwlwifi.20220129105618.6c31f6a2dcfc.If311c1d548bc5f7157a449e848ea01f71f5592eb@changeid
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
> .../net/wireless/intel/iwlwifi/cfg/22000.c | 6 ++++
> drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 29 +++++++++++++++++--
> .../net/wireless/intel/iwlwifi/iwl-config.h | 1 +
> drivers/net/wireless/intel/iwlwifi/iwl-prph.h | 2 ++
> 4 files changed, 36 insertions(+), 2 deletions(-)
Please always test-build your patches before sending them. This broke
the build:
drivers/net/wireless/intel/iwlwifi/fw/dbg.c:2282:33: error: initialization of ‘void * (*)(struct iwl_fw_runtime *, struct iwl_dump_ini_region_data *, void *)’ from incompatible pointer type ‘void * (*)(struct iwl_fw_runtime *, struct iwl_dump_ini_region_data *, void *, u32)’ {aka ‘void * (*)(struct iwl_fw_runtime *, struct iwl_dump_ini_region_data *, void *, unsigned int)’} [-Werror=incompatible-pointer-types]
2282 | .fill_mem_hdr = iwl_dump_ini_mon_dbgi_fill_header,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{sigh}
Odds are your other backports will too, so I'm going to ignore them as
well and wait for working ones.
next prev parent reply other threads:[~2022-04-14 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 13:16 FAILED: patch "[PATCH] iwlwifi: yoyo: fix DBGI_SRAM ini dump header." failed to apply to 5.17-stable tree gregkh
2022-04-13 8:06 ` [PATCH 5.17] iwlwifi: yoyo: fix DBGI_SRAM ini dump header Luca Coelho
2022-04-14 10:59 ` Greg KH [this message]
2022-04-13 8:07 ` [PATCH 5.16] " Luca Coelho
2022-04-13 8:07 ` [PATCH 5.15] " Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ylf+pLW54GU23JNS@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gregory.greenman@intel.com \
--cc=luca@coelho.fi \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.