From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB015C433F5 for ; Thu, 14 Apr 2022 16:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241427AbiDNQHC (ORCPT ); Thu, 14 Apr 2022 12:07:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348944AbiDNPkM (ORCPT ); Thu, 14 Apr 2022 11:40:12 -0400 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9BFBC5583; Thu, 14 Apr 2022 08:19:00 -0700 (PDT) Received: by mail-oi1-f182.google.com with SMTP id 12so5699020oix.12; Thu, 14 Apr 2022 08:19:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rTnbii0TkfiP0IgylH+LPQeyfK4chNSMZIeQMu2dlZ0=; b=44Lvk3aKbxtOBzPkD6hHm1CjWoWpgA2QoNMfqHRlgXnizhX3EsCyxHVnWDrEIuFXZm OKSKF4h0xAwKNpzt8GbSoFbgZsmTbNDz1GtOV5S0ZkB8M6fFedYV8Yz1LTp4NzMNlmml xLJz1eR0hN8/+MRc9t087Y/+QNhiOgMIcu5YLWG8cbXEiAuZyW8Ppp1zRBKBwRvjQ1MK 0Jsf1Uj/PGGIz/+qgviNF3h9+NwbCYm7YkPEWVCnDNuA9oGJ/maWtdjJWYj7LG2wQlNb WDaNDTnh3Jr4cjrm68uhWtIzKOxNPXp0zM+QPN45OyFobk68bnRaT3N6NATyVEBQPWmi cG1A== X-Gm-Message-State: AOAM5337BI4i00pmA/TgLak4RiYeZCtyuB0uTv8alrQdJGGz8JsgKKAy sPCyM5TH9XBS6myCBshuMg== X-Google-Smtp-Source: ABdhPJx97/FQcjk9Be6OMKujrhUC85sEPYMS6H5cAeRSjdGYelkOgG068e0xOR/WfxQnx5K/o4EfsQ== X-Received: by 2002:aca:2418:0:b0:2ee:f7da:795f with SMTP id n24-20020aca2418000000b002eef7da795fmr1833724oic.276.1649949539942; Thu, 14 Apr 2022 08:18:59 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c19-20020a9d7853000000b005cdbc0f02ccsm106314otm.68.2022.04.14.08.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 08:18:59 -0700 (PDT) Received: (nullmailer pid 2073887 invoked by uid 1000); Thu, 14 Apr 2022 15:18:58 -0000 Date: Thu, 14 Apr 2022 10:18:58 -0500 From: Rob Herring To: =?utf-8?B?cWluamlhblvopoPlgaVd?= Cc: Krzysztof Kozlowski , "mturquette@baylibre.com" , "sboyd@kernel.org" , "tglx@linutronix.de" , "maz@kernel.org" , "p.zabel@pengutronix.de" , "linux@armlinux.org.uk" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, Apr 14, 2022 at 07:06:12AM +0000, qinjian[覃健] wrote: > > > > +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > > > +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > > > + > > > +#define XTAL 27000000 > > > > This looks like frequency which usually does not belong to bindings. Why > > do you need it here? > > > > OK, I'll remove it. If that's the input frequency to the clock controller and it could possibly change, then it should be defined in DT with a 'fixed-clock' node and 'clocks' property in the clock controller. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED748C433EF for ; Thu, 14 Apr 2022 15:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IeA6a0WQZDDkUXEsRnG8CL2dks7JebrK9GWD9tiOJf0=; b=mwp2EDn5a+uzvo cyUpBvGu1/TqmZYrEo8cn+96jo+GFmBcHnF1i4ekTkG5akd9EHcSO/HpZDkIhvRbvSfvse+Z7oYxG CIRVhQMjBu0pvFycJ9KIE87kx5gE2wg7Mke4TWbrZ57/6pnsg1aLAsoTrkXjJP4uZwQMFhCCqZ3XD 4iG3ZtRv8d7a2o39No4kKvRpog9nebU4xxwCHMfJmXO6UV1M9PKT6xZfdQ7MPuT7tPZR4nbFgHaom prm9AHMGOXfJXs1dWqvj9fA9/c+X6ZOYhW2mDmKbk4K936yGuRlH6123YzE6jjtqHSZ3q+qj2wCLe Y3bNpLvBhHO2yt9VmyAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nf1FR-006CId-MR; Thu, 14 Apr 2022 15:19:05 +0000 Received: from mail-oi1-f181.google.com ([209.85.167.181]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nf1FO-006CHS-AX for linux-arm-kernel@lists.infradead.org; Thu, 14 Apr 2022 15:19:03 +0000 Received: by mail-oi1-f181.google.com with SMTP id b188so5696080oia.13 for ; Thu, 14 Apr 2022 08:19:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rTnbii0TkfiP0IgylH+LPQeyfK4chNSMZIeQMu2dlZ0=; b=RICgYTOHMLD2ooXf5iYU1GFCJnavZvQSmtiXKUxJRW7M0gFjNgHnVbpTBS1tMwr8FT jr2/LYl0AYbsA2UHtK0PvUlmZ+ahibkC9PQlV0AFZhV3ZCx616kR6WJseZngJmYt10Tq hlZBWvgWPr60mCD3jsEamS60F45gI21a9a9iEXpLDuACbLbp4yIk7bF99mFXZwn7DDds I8q6wP2iwAt3oyE5A5RL5MZ0ijJIfFPkYfzcyXFKyQOc88ALWL6dRoxra9TBmL9IBhO+ eobdzTg3FcLVKXBYG336RgGb1tCUsqTiwP7Fw77hzxVFPtgwXJdDI8y5xTo6IHzIhdh1 Uugw== X-Gm-Message-State: AOAM5329v98NzkRyb8L70fETkgOxHTI7FAJl9jqEK128FtsV9i8YrWUi 8oZDCE8o0PcSepk3UOBDjw== X-Google-Smtp-Source: ABdhPJx97/FQcjk9Be6OMKujrhUC85sEPYMS6H5cAeRSjdGYelkOgG068e0xOR/WfxQnx5K/o4EfsQ== X-Received: by 2002:aca:2418:0:b0:2ee:f7da:795f with SMTP id n24-20020aca2418000000b002eef7da795fmr1833724oic.276.1649949539942; Thu, 14 Apr 2022 08:18:59 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c19-20020a9d7853000000b005cdbc0f02ccsm106314otm.68.2022.04.14.08.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 08:18:59 -0700 (PDT) Received: (nullmailer pid 2073887 invoked by uid 1000); Thu, 14 Apr 2022 15:18:58 -0000 Date: Thu, 14 Apr 2022 10:18:58 -0500 From: Rob Herring To: =?utf-8?B?cWluamlhblvopoPlgaVd?= Cc: Krzysztof Kozlowski , "mturquette@baylibre.com" , "sboyd@kernel.org" , "tglx@linutronix.de" , "maz@kernel.org" , "p.zabel@pengutronix.de" , "linux@armlinux.org.uk" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: Re: [PATCH v13 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_081902_397175_2C3567B7 X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMTQsIDIwMjIgYXQgMDc6MDY6MTJBTSArMDAwMCwgcWluamlhblvopoPlgaVd IHdyb3RlOgo+IAo+ID4gPiArI2lmbmRlZiBfRFRfQklORElOR1NfQ0xPQ0tfU1VOUExVU19TUDcw MjFfSAo+ID4gPiArI2RlZmluZSBfRFRfQklORElOR1NfQ0xPQ0tfU1VOUExVU19TUDcwMjFfSAo+ ID4gPiArCj4gPiA+ICsjZGVmaW5lIFhUQUwgICAgICAgICAgICAyNzAwMDAwMAo+ID4gCj4gPiBU aGlzIGxvb2tzIGxpa2UgZnJlcXVlbmN5IHdoaWNoIHVzdWFsbHkgZG9lcyBub3QgYmVsb25nIHRv IGJpbmRpbmdzLiBXaHkKPiA+IGRvIHlvdSBuZWVkIGl0IGhlcmU/Cj4gPiAKPiAKPiBPSywgSSds bCByZW1vdmUgaXQuCgpJZiB0aGF0J3MgdGhlIGlucHV0IGZyZXF1ZW5jeSB0byB0aGUgY2xvY2sg Y29udHJvbGxlciBhbmQgaXQgY291bGQgCnBvc3NpYmx5IGNoYW5nZSwgdGhlbiBpdCBzaG91bGQg YmUgZGVmaW5lZCBpbiBEVCB3aXRoIGEgJ2ZpeGVkLWNsb2NrJyAKbm9kZSBhbmQgJ2Nsb2Nrcycg cHJvcGVydHkgaW4gdGhlIGNsb2NrIGNvbnRyb2xsZXIuCgpSb2IKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==