From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Date: Thu, 14 Apr 2022 15:59:19 +0200 Subject: [PATCH v7 2/8] x86/crash: Introduce new options to support cpu and memory hotplug In-Reply-To: <20220413164237.20845-3-eric.devolder@oracle.com> References: <20220413164237.20845-1-eric.devolder@oracle.com> <20220413164237.20845-3-eric.devolder@oracle.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kexec@lists.infradead.org On Wed, Apr 13, 2022 at 12:42:31PM -0400, Eric DeVolder wrote: > CRASH_HOTPLUG is to enable cpu and memory hotplug support of crash. What for? Why don't you put all that new code you're adding under an MEMORY_HOTPLUG ifdef? It seems you would need to do that when memory hotplug is enabled, anyway. Also, looking further into your patchset, you have ugly ifdeffery. Instead of that, pls add stubs for the !MEMORY_HOTPLUG case so that everything is abstracted away in the headers. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA00C433F5 for ; Thu, 14 Apr 2022 15:31:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241468AbiDNP1B (ORCPT ); Thu, 14 Apr 2022 11:27:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348147AbiDNOCT (ORCPT ); Thu, 14 Apr 2022 10:02:19 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0752663E4 for ; Thu, 14 Apr 2022 06:59:21 -0700 (PDT) Received: from zn.tnic (p2e55d808.dip0.t-ipconnect.de [46.85.216.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8F8BF1EC0528; Thu, 14 Apr 2022 15:59:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1649944755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=i8SW726GJn4l9wyfwUlIuTGzZbbab4SGdiSCBm6wmTs=; b=HKqTSvykELA/WQ9v7czQk/OhKV3ZglpPMR5mc0FM5XQOHfg/Gg3B8L7Kjzmbl7cNBG9sBH Xk7CSx3KVxba22H9jpJG/Fq92ws5ZwNBw8QYnjyIJFUzIqhZFUGhnz6qmA/cspDacbh381 GI5VrKvnM8MoAEBbmD2Zpn5wKdhXD8s= Date: Thu, 14 Apr 2022 15:59:19 +0200 From: Borislav Petkov To: Eric DeVolder Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH v7 2/8] x86/crash: Introduce new options to support cpu and memory hotplug Message-ID: References: <20220413164237.20845-1-eric.devolder@oracle.com> <20220413164237.20845-3-eric.devolder@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220413164237.20845-3-eric.devolder@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 13, 2022 at 12:42:31PM -0400, Eric DeVolder wrote: > CRASH_HOTPLUG is to enable cpu and memory hotplug support of crash. What for? Why don't you put all that new code you're adding under an MEMORY_HOTPLUG ifdef? It seems you would need to do that when memory hotplug is enabled, anyway. Also, looking further into your patchset, you have ugly ifdeffery. Instead of that, pls add stubs for the !MEMORY_HOTPLUG case so that everything is abstracted away in the headers. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette