From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kvm-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3830EC433F5
	for <kvm@archiver.kernel.org>; Thu, 14 Apr 2022 21:36:40 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S241468AbiDNVjD (ORCPT <rfc822;kvm@archiver.kernel.org>);
        Thu, 14 Apr 2022 17:39:03 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56644 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232065AbiDNVjB (ORCPT <rfc822;kvm@vger.kernel.org>);
        Thu, 14 Apr 2022 17:39:01 -0400
Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AD906A406
        for <kvm@vger.kernel.org>; Thu, 14 Apr 2022 14:36:35 -0700 (PDT)
Received: by mail-pl1-x634.google.com with SMTP id t12so5754539pll.7
        for <kvm@vger.kernel.org>; Thu, 14 Apr 2022 14:36:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to;
        bh=ZwqsSd8kK//Ty3psSXbHkN/qQik6vo6YZ0uDueArJzs=;
        b=rSdQRfJjuZsb4h+Fu1jiDnVTCJBmeCSwUBTVNomZ5qdc6nxby4DM9FZTFmV9m1HXGV
         JZF7Mhn7w+8f0QZ6saI+07Dm6ngeweQYMdPPnGIN5pqUWo++ilejxzQR4CXSJgsdcddH
         Z8BRvmrPDnhoobFy1t/iI8BLxqs9/dzBFRftvSKticHSkTLhZb4NJvzOlovlfQsk8+xO
         CcRiG3BScyhOvQjj+AQNKbqqBmU8bmvd8Fqf9NzlERdR/lof59yeFO9LlT2H7kP6JzFF
         PPXvNuwwEeE56IWQ30Lg7ZTTkcOq8exKo/9AQPn/8VTjlYFGbpwv94/xSM9PxauUho2o
         YJJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=ZwqsSd8kK//Ty3psSXbHkN/qQik6vo6YZ0uDueArJzs=;
        b=DlcMJPz64CazG+O3qu6dVCuolgPii0fJvNefvyt0iQQXBQxe1OGOMEOpqiXzNcy/Uq
         cPqGHlM1JG8YZVNiIrQQWADVBqXcsdL0ZX84iVX8KLJGOEGX8JbUneokFjdAI8skhQ8b
         1ZgIXuWaeMYKv/KQbUCLzq6L6yuJedJPpr/+w9+SlsyLs9ZtMDrP1vhD6pGSkxZMBa7m
         Nzbm1L02pyxkMIe9iNVhrfT2h+jwT+/XUcMcdSJS/Y4pOcyeAlavQEv2F6ngRVWj3JjX
         HKG2BFj0HqTyxNQ+lhL9yC7voR8xcM5smi/2FXMAF829ZHkta7TfvkkCstxgExKPi+CX
         LNjA==
X-Gm-Message-State: AOAM533xUrsEkhFdjHbtXYSsSAPwnNJsPM0i4VecEO9JicTCvFaOTpbS
        UK1mQnqxvjl9BOfYadywhp4XvQ==
X-Google-Smtp-Source: ABdhPJxShsm33JtSld9PyGypzrkdDGtOwK8ZlnrDjirccYqaCHu+mWwMwAhczp8ZxD/X+N8l6YvZAQ==
X-Received: by 2002:a17:903:249:b0:153:857c:a1fe with SMTP id j9-20020a170903024900b00153857ca1femr49062962plh.44.1649972194773;
        Thu, 14 Apr 2022 14:36:34 -0700 (PDT)
Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157])
        by smtp.gmail.com with ESMTPSA id y3-20020a056a00190300b004fa2411bb92sm818081pfi.93.2022.04.14.14.36.34
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 14 Apr 2022 14:36:34 -0700 (PDT)
Date:   Thu, 14 Apr 2022 21:36:30 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Ben Gardon <bgardon@google.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Peter Xu <peterx@redhat.com>,
        David Matlack <dmatlack@google.com>,
        Jim Mattson <jmattson@google.com>,
        David Dunn <daviddunn@google.com>,
        Jing Zhang <jingzhangos@google.com>,
        Junaid Shahid <junaids@google.com>
Subject: Re: [PATCH v5 06/10] KVM: selftests: Add NX huge pages test
Message-ID: <YliT3rWLDDMjjLJN@google.com>
References: <20220413175944.71705-1-bgardon@google.com>
 <20220413175944.71705-7-bgardon@google.com>
 <YldQOJjqLJxRz6Ea@google.com>
 <CANgfPd-LOxaJSvOhxQQ2MvJauimUHugrKRi0TFxNpq0ShL8rRg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANgfPd-LOxaJSvOhxQQ2MvJauimUHugrKRi0TFxNpq0ShL8rRg@mail.gmail.com>
Precedence: bulk
List-ID: <kvm.vger.kernel.org>
X-Mailing-List: kvm@vger.kernel.org

On Thu, Apr 14, 2022, Ben Gardon wrote:
> On Wed, Apr 13, 2022 at 3:35 PM Sean Christopherson <seanjc@google.com> wrote:
> > > diff --git a/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.sh b/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.sh
> > > new file mode 100755
> > > index 000000000000..19fc95723fcb
> > > --- /dev/null
> > > +++ b/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.sh
> > > @@ -0,0 +1,25 @@
> > > +#!/bin/bash
> > > +# SPDX-License-Identifier: GPL-2.0-only */
> > > +
> > > +# tools/testing/selftests/kvm/nx_huge_page_test.sh
> > > +# Copyright (C) 2022, Google LLC.
> >
> > This should either check for root or use sudo.
> 
> Is there not any scenario where the below setup commands could work
> without root?

Technically, yes, someone could be running the test as a non-root user with
the necessary permissions.  Practically speaking, I would be surprised if anyone
configures module params in that way.

That said, there's certainly no harm in using sudo as a fall back.