From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yang Jihong <yangjihong1@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, ak@linux.intel.com, adrian.hunter@intel.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: make util/data.h self-contained
Date: Sat, 30 Apr 2022 12:31:53 -0300 [thread overview]
Message-ID: <Ym1WaannQyQ+Fn3C@kernel.org> (raw)
In-Reply-To: <20220429090539.212448-1-yangjihong1@huawei.com>
Em Fri, Apr 29, 2022 at 05:05:39PM +0800, Yang Jihong escreveu:
> struct perf_data in util/data.h uses "u64" data type, which is defined in
> "linux/types.h". If only include util/data.h, following compilation error
> occur:
>
> util/data.h:38:3: error: unknown type name ‘u64’
> u64 version;
> ^~~
>
> Solution: include "linux/types.h." to resolve self-contained issues
Thanks, applied.
- Arnaldo
> Fixes: 258031c017c35 (perf header: Add DIR_FORMAT feature to describe directory data)
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
> ---
> tools/perf/util/data.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/data.h b/tools/perf/util/data.h
> index c9de82af5584..1402d9657ef2 100644
> --- a/tools/perf/util/data.h
> +++ b/tools/perf/util/data.h
> @@ -4,6 +4,7 @@
>
> #include <stdio.h>
> #include <stdbool.h>
> +#include <linux/types.h>
>
> enum perf_data_mode {
> PERF_DATA_MODE_WRITE,
> --
> 2.30.GIT
--
- Arnaldo
prev parent reply other threads:[~2022-04-30 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 9:05 [PATCH] perf: make util/data.h self-contained Yang Jihong
2022-04-30 15:31 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ym1WaannQyQ+Fn3C@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.