From: ira.weiny@intel.com
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Hridya Valsaraju" <hridya@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
linux-kernel@vger.kernel.org,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH v2 0/3] binder: Use kmap_local_page() in binder_alloc.c
Date: Sat, 30 Apr 2022 22:48:08 -0700 [thread overview]
Message-ID: <Ym4fAd501sUmEdLB@iweiny-server> (raw)
In-Reply-To: <20220425175754.8180-1-fmdefrancesco@gmail.com>
On Mon, Apr 25, 2022 at 07:57:51PM +0200, Fabio M. De Francesco wrote:
> Use kmap_local_page() in binder_alloc.c because kmap() and kmap_atomic()
> are being deprecated and kmap_local_page() is preferred where it is
> feasible.
>
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible. Furthermore, the mapping can be acquired from any
> context, including interrupts.
For the series:
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>
> Fabio M. De Francesco (3):
> binder: Use memset_page() in binder_alloc_clear_buf()
> binder: Use kmap_local_page() in binder_alloc_copy_user_to_buffer()
> binder: Use memcpy_{to,from}_page() in binder_alloc_do_buffer_copy()
>
> drivers/android/binder_alloc.c | 22 +++++-----------------
> 1 file changed, 5 insertions(+), 17 deletions(-)
>
> --
> 2.34.1
>
prev parent reply other threads:[~2022-05-01 5:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 17:57 [PATCH v2 0/3] binder: Use kmap_local_page() in binder_alloc.c Fabio M. De Francesco
2022-04-25 17:57 ` [PATCH v2 1/3] binder: Use memset_page() in binder_alloc_clear_buf() Fabio M. De Francesco
2022-04-25 17:57 ` [PATCH v2 2/3] binder: Use kmap_local_page() in binder_alloc_copy_user_to_buffer() Fabio M. De Francesco
2022-04-25 17:57 ` [PATCH v2 3/3] binder: Use memcpy_{to,from}_page() in binder_alloc_do_buffer_copy() Fabio M. De Francesco
2022-05-01 5:48 ` ira.weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ym4fAd501sUmEdLB@iweiny-server \
--to=ira.weiny@intel.com \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.