From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Daire McNamara" <daire.mcnamara@microchip.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, kernel@pengutronix.de,
"Ian Cowan" <ian@linux.cowan.aero>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] PCI: microchip: Add a missing semicolon
Date: Wed, 20 Apr 2022 08:27:05 -0500 [thread overview]
Message-ID: <YmAKKcBVGuBHwhUb@robh.at.kernel.org> (raw)
In-Reply-To: <20220420065832.14173-1-u.kleine-koenig@pengutronix.de>
On Wed, Apr 20, 2022 at 08:58:32AM +0200, Uwe Kleine-König wrote:
> If the driver is configured as a module (after allowing this by changing
> PCIE_MICROCHIP_HOST from bool to tristate) the missing semicolon makes the
> compiler very unhappy. While there isn't a real problem as
> MODULE_DEVICE_TABLE always evaluates to nothing for a built-in driver,
> do it right for consistency with other drivers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I wonder if there is a technical reason to have PCIE_MICROCHIP_HOST (and
> some others) only bool. With this patch applied the driver compiles just
> fine with PCIE_MICROCHIP_HOST=m.
Historical copy-n-paste.
Rob
next prev parent reply other threads:[~2022-04-20 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 6:58 [PATCH] PCI: microchip: Add a missing semicolon Uwe Kleine-König
2022-04-20 7:54 ` Conor.Dooley
2022-04-20 10:40 ` Daire.McNamara
2022-04-20 13:27 ` Rob Herring [this message]
2022-04-20 14:43 ` Uwe Kleine-König
2022-04-25 13:02 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmAKKcBVGuBHwhUb@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=daire.mcnamara@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=ian@linux.cowan.aero \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.