From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D7C2510F1F6 for ; Wed, 20 Apr 2022 19:30:45 +0000 (UTC) Date: Wed, 20 Apr 2022 15:30:40 -0400 From: Rodrigo Vivi To: "Srivatsa, Anusha" Message-ID: References: <20220420184628.412506-1-rodrigo.vivi@intel.com> <671434dd9c4241e481bcf4abb0f2666c@intel.com> <3dd9fb53d204f1e7865b74bb675078fb462ed958.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc.c: Remove PC8+ dependency from DC9. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "igt-dev@lists.freedesktop.org" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Wed, Apr 20, 2022 at 03:27:19PM -0400, Srivatsa, Anusha wrote: > > > > -----Original Message----- > > From: Vivi, Rodrigo > > Sent: Wednesday, April 20, 2022 12:09 PM > > To: igt-dev@lists.freedesktop.org; Srivatsa, Anusha > > > > Cc: Gupta, Anshuman ; Deak, Imre > > > > Subject: Re: [PATCH i-g-t] tests/i915/i915_pm_dc.c: Remove PC8+ > > dependency from DC9. > > > > On Wed, 2022-04-20 at 12:07 -0700, Srivatsa, Anusha wrote: > > > > > > > > > > -----Original Message----- > > > > From: Vivi, Rodrigo > > > > Sent: Wednesday, April 20, 2022 11:46 AM > > > > To: igt-dev@lists.freedesktop.org > > > > Cc: Vivi, Rodrigo ; Deak, Imre > > > > ; Gupta, Anshuman > > ; > > > > Srivatsa, Anusha > > > > Subject: [PATCH i-g-t] tests/i915/i915_pm_dc.c: Remove PC8+ > > > > dependency from DC9. > > > > > > > > Different from DC6, DC9 does not depend on the BIOS/PCU to execute > > > > save and restore or any other sequence when going to PC9/PC10. > > > > > > > > DC9 actually depends on D3 and PCODE simply remove power if SW > > > > allowed. > > > > > > Is this the case for both igfx and dgfx? > > > > yes > > > When the check was introduced- for ICL, wasn’t this the requirement though? How come we have not had issues on ICL+ platforms till now if the check was wrong. The foils I'm checking is for gen9+. I have fwded it to you couple weeks ago. DC9 never had any dependency on Package-C states, but only on D3. Even on BXT. I believe this addition here was accidental when adding the checks for DC6. > > Anusha > > > > > > Anusha > > > > > > > Cc: Imre Deak > > > > Cc: Anshuman Gupta > > > > Cc: Anusha Srivatsa > > > > Signed-off-by: Rodrigo Vivi > > > > --- > > > >  tests/i915/i915_pm_dc.c | 2 -- > > > >  1 file changed, 2 deletions(-) > > > > > > > > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index > > > > 2c2c5086..9a22246c 100644 > > > > --- a/tests/i915/i915_pm_dc.c > > > > +++ b/tests/i915/i915_pm_dc.c > > > > @@ -531,8 +531,6 @@ int main(int argc, char *argv[]) > > > > > > > >         igt_describe("This test validates display engine entry to > > > > DC9 state"); > > > >         igt_subtest("dc9-dpms") { > > > > - > > > >         igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_ > > > > fd), > > > > -                               "PC8+ residencies not supported\n"); > > > >                 test_dc9_dpms(&data); > > > >         } > > > > > > > > -- > > > > 2.34.1 > > > >