From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 773F7C4332F for ; Thu, 21 Apr 2022 12:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384543AbiDUMaO (ORCPT ); Thu, 21 Apr 2022 08:30:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384630AbiDUMaK (ORCPT ); Thu, 21 Apr 2022 08:30:10 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5E7531372 for ; Thu, 21 Apr 2022 05:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=igRtZHcpgynSUjzrTXxfuwObmrQFk9SFfrkdbrtI60s=; b=oyVLLdFx+HV4UdDKWQ98XJI8TR TNJVD9Eib/so3B8jXoU02H4RvkkrmYidMvVuTgWLmWI+DlNLg6tvrs+D0poQJf8jdHtw0QFWFUCsh iSBj8jgluAlQpbV3KlzKo2dRtWktD4TIpNLXpxNkJwX1nVRk88MywYaKF7yxVw2xkAzk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nhVu0-00Gncv-UR; Thu, 21 Apr 2022 14:27:16 +0200 Date: Thu, 21 Apr 2022 14:27:16 +0200 From: Andrew Lunn To: Josua Mayer Cc: netdev@vger.kernel.org, alvaro.karsz@solid-run.com, Russell King , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Subject: Re: [PATCH v2 3/3] ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9 Message-ID: References: <20220410104626.11517-1-josua@solid-run.com> <20220419102709.26432-1-josua@solid-run.com> <20220419102709.26432-4-josua@solid-run.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419102709.26432-4-josua@solid-run.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 19, 2022 at 01:27:09PM +0300, Josua Mayer wrote: > Since SoM revision 1.9 the PHY has been replaced with an ADIN1300, > add an entry for it next to the original. > > Co-developed-by: Alvaro Karsz > Signed-off-by: Alvaro Karsz > Signed-off-by: Josua Mayer > --- > V1 -> V2: changed dts property name > > arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > index f86efd0ccc40..d46182095d79 100644 > --- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > @@ -83,6 +83,12 @@ ethernet-phy@4 { > qca,clk-out-frequency = <125000000>; > qca,smarteee-tw-us-1g = <24>; > }; > + > + /* ADIN1300 (som rev 1.9 or later) */ > + ethernet-phy@1 { > + reg = <1>; > + adi,phy-output-clock = "125mhz-free-running"; > + }; There is currently the comment: * The PHY can appear at either address 0 or 4 due to the * configuration (LED) pin not being pulled sufficiently. */ It would be good to add another comment about this PHY at address 1. Andrew