From: Solomon Tan <wjsota@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk
Subject: Re: [PATCH] staging: r8188eu: use in-kernel ieee channel
Date: Fri, 22 Apr 2022 07:44:42 +0800 [thread overview]
Message-ID: <YmHsannu/vcKX9Kk@ArchDesktop> (raw)
In-Reply-To: <20220421170010.GD2462@kadam>
On Thu, Apr 21, 2022 at 08:00:10PM +0300, Dan Carpenter wrote:
> On Thu, Apr 21, 2022 at 09:58:12AM +0800, Solomon Tan wrote:
> > The rtw_ieee80211_channel structure just duplicates the in-kernel
> > ieee80211_channel structure
>
> When you say that they are duplicates, I expected them to be the same
> but they're not at all. ieee80211_channel has a bunch more struct
> members.
>
> I don't really have a problem with the change necessarily but the commit
> message should not have mislead me.
Sorry about that. I will amend the commit message and send it as v2.
Thank you for the review.
>
> regards,
> dan carpenter
>
Cheers,
Solomon
prev parent reply other threads:[~2022-04-21 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 1:58 [PATCH] staging: r8188eu: use in-kernel ieee channel Solomon Tan
2022-04-21 17:00 ` Dan Carpenter
2022-04-21 23:44 ` Solomon Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmHsannu/vcKX9Kk@ArchDesktop \
--to=wjsota@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.