From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Fri, 22 Apr 2022 14:26:14 +0200 Subject: [PATCH v3 1/3] firmware: Add boot information to sysfs In-Reply-To: References: <20220204072234.304543-1-joel@jms.id.au> <20220204072234.304543-2-joel@jms.id.au> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Apr 22, 2022 at 11:05:46AM +0200, Arnd Bergmann wrote: > On Fri, Apr 22, 2022 at 8:46 AM Greg Kroah-Hartman > wrote: > > On Fri, Feb 04, 2022 at 05:52:32PM +1030, Joel Stanley wrote: > > > +What: /sys/firmware/bootinfo/* > > > +Date: Jan 2022 > > > > It isn't January anymore :) > > The patch was sent on Feb 4, I would expect that to be close enough. Does this > need to be the month of the kernel release it is merged into instead? That's usually best, but at least the month the patch was sent in is good. Also I notice there's no "who is responsible for this" entry here. > > > > +Description: > > > + A system can expose information about how it was started in > > > + this directory. > > > > I do not understand what you mean by "how it was started". > > > > > + This information is agnostic as to the firmware implementation. > > > > How? This should be very firmware specific. > > The original patch was specific to a particular SoC vendor. Since the > information provided here is fairly generic in the end, I asked for > the interface > to be generalized to the point that it can be reused across multiple > vendors and architectures. Ok, and is that what this interface provides? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0031C433EF for ; Fri, 22 Apr 2022 12:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dFdNXcjRo80/lzTfv/vjVEQGwUlPKCmqzphQXSwnsdM=; b=T52aLVGpjZs+R3 NspmmQ7xfzx4sSh/9ZQ0DtYAUEWIczZT507xf9gb24K8f5ODWrk5XWx+02YJpbyhF2FGjpPUR+py4 oT7i+SC7IgRKKbzzLIVMAgSYytkIRyqEkS4tV2w7BL7czROwDqGkLFOEXMqR/kET2nSx0cxDtBWZO VeU7U+OByUrBCnuPsc+LQFYO2wp32CVioCKuSO4TYOaSl+mb1tSd0eq024upi9EoKexeC5XAwzXMp Dv/ssjDB24Zxys41Ncq7JvkYsbEIeZiQCdW2FXf4yb9QiFnXx4O15VbLEib6WmDd2jOB5/yFWCa9+ Hv55bk7xYqpvrqs43MnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhsMh-000O5C-9n; Fri, 22 Apr 2022 12:26:23 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhsMe-000O4E-86 for linux-arm-kernel@lists.infradead.org; Fri, 22 Apr 2022 12:26:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7AAC2B82A99; Fri, 22 Apr 2022 12:26:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6671C385A4; Fri, 22 Apr 2022 12:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650630377; bh=YWvN2GspVnHvlnte3uDLsyT/zdRooy5HOmSXH4ILyuc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r8a9Yh+Ht3Kz/97UlvVaAMk64r8KVfczuaCGO5oW4WhL0vrR+wdX3Iy9FNFL6vXgh 5oHodwiiUfOQe0i8o2kTf4uxUnXASb0L3G11/qhY5mEzrLulbIZ4WTcKPnShqaFHSF Oz/J2vqFheMqLYwwu+IhZ/6pZ783fWKjvp6JaOr8= Date: Fri, 22 Apr 2022 14:26:14 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Joel Stanley , Andrew Jeffery , "Rafael J . Wysocki" , Robin Murphy , Linux Kernel Mailing List , Linux ARM , linux-aspeed Subject: Re: [PATCH v3 1/3] firmware: Add boot information to sysfs Message-ID: References: <20220204072234.304543-1-joel@jms.id.au> <20220204072234.304543-2-joel@jms.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220422_052620_464931_141D8435 X-CRM114-Status: GOOD ( 23.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 22, 2022 at 11:05:46AM +0200, Arnd Bergmann wrote: > On Fri, Apr 22, 2022 at 8:46 AM Greg Kroah-Hartman > wrote: > > On Fri, Feb 04, 2022 at 05:52:32PM +1030, Joel Stanley wrote: > > > +What: /sys/firmware/bootinfo/* > > > +Date: Jan 2022 > > > > It isn't January anymore :) > > The patch was sent on Feb 4, I would expect that to be close enough. Does this > need to be the month of the kernel release it is merged into instead? That's usually best, but at least the month the patch was sent in is good. Also I notice there's no "who is responsible for this" entry here. > > > > +Description: > > > + A system can expose information about how it was started in > > > + this directory. > > > > I do not understand what you mean by "how it was started". > > > > > + This information is agnostic as to the firmware implementation. > > > > How? This should be very firmware specific. > > The original patch was specific to a particular SoC vendor. Since the > information provided here is fairly generic in the end, I asked for > the interface > to be generalized to the point that it can be reused across multiple > vendors and architectures. Ok, and is that what this interface provides? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EDAFC433F5 for ; Fri, 22 Apr 2022 12:26:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1447456AbiDVM3Q (ORCPT ); Fri, 22 Apr 2022 08:29:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1389742AbiDVM3N (ORCPT ); Fri, 22 Apr 2022 08:29:13 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC21956435 for ; Fri, 22 Apr 2022 05:26:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1140ACE2943 for ; Fri, 22 Apr 2022 12:26:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6671C385A4; Fri, 22 Apr 2022 12:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650630377; bh=YWvN2GspVnHvlnte3uDLsyT/zdRooy5HOmSXH4ILyuc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r8a9Yh+Ht3Kz/97UlvVaAMk64r8KVfczuaCGO5oW4WhL0vrR+wdX3Iy9FNFL6vXgh 5oHodwiiUfOQe0i8o2kTf4uxUnXASb0L3G11/qhY5mEzrLulbIZ4WTcKPnShqaFHSF Oz/J2vqFheMqLYwwu+IhZ/6pZ783fWKjvp6JaOr8= Date: Fri, 22 Apr 2022 14:26:14 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Joel Stanley , Andrew Jeffery , "Rafael J . Wysocki" , Robin Murphy , Linux Kernel Mailing List , Linux ARM , linux-aspeed Subject: Re: [PATCH v3 1/3] firmware: Add boot information to sysfs Message-ID: References: <20220204072234.304543-1-joel@jms.id.au> <20220204072234.304543-2-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2022 at 11:05:46AM +0200, Arnd Bergmann wrote: > On Fri, Apr 22, 2022 at 8:46 AM Greg Kroah-Hartman > wrote: > > On Fri, Feb 04, 2022 at 05:52:32PM +1030, Joel Stanley wrote: > > > +What: /sys/firmware/bootinfo/* > > > +Date: Jan 2022 > > > > It isn't January anymore :) > > The patch was sent on Feb 4, I would expect that to be close enough. Does this > need to be the month of the kernel release it is merged into instead? That's usually best, but at least the month the patch was sent in is good. Also I notice there's no "who is responsible for this" entry here. > > > > +Description: > > > + A system can expose information about how it was started in > > > + this directory. > > > > I do not understand what you mean by "how it was started". > > > > > + This information is agnostic as to the firmware implementation. > > > > How? This should be very firmware specific. > > The original patch was specific to a particular SoC vendor. Since the > information provided here is fairly generic in the end, I asked for > the interface > to be generalized to the point that it can be reused across multiple > vendors and architectures. Ok, and is that what this interface provides? thanks, greg k-h