From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E64CC433EF for ; Fri, 22 Apr 2022 13:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KlmyVzh7xNbLKdghOOo8kYNwJQdYySXSyoUdknffdWc=; b=LiqOEErvgvUhC9 T5aG0qnE+xAmJ/zKgs3EJzozyvhVt469jl7qwjrW7HAxaz/trdcao9FthXv9thWwc0vU/q7quynwR TIrfkcf6zepSJPcHBKX+mqy50CHaBFz5JQx/wIhAAaeqrNaXN2uDInReaWxzhO/b9GFBskO5EURuf EGfhXIU4lJQMGyZfBf1QBGUI/HQtdbterQam7FqWvzpTX+AxCB7beuEgZdGwbo5xdl+Bx6tQnNHc/ QUAh9vW97dYjPs1P/OGkxppKZhBNrZTw7AvCDChJACfxr2IxBVejsvrfgtMzhaHwyCTs8MGG/d+B2 ZzY1sgNf1K77ZbsFzneQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhtbQ-000fO8-VK; Fri, 22 Apr 2022 13:45:41 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhtbN-000fNH-JT for linux-arm-kernel@lists.infradead.org; Fri, 22 Apr 2022 13:45:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 34A5FB82C37; Fri, 22 Apr 2022 13:45:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0072C385A4; Fri, 22 Apr 2022 13:45:33 +0000 (UTC) Date: Fri, 22 Apr 2022 14:45:30 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/mm: Compute PTRS_PER_[PMD|PUD] independently of PTRS_PER_PTE Message-ID: References: <20220408041009.1259701-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220408041009.1259701-1-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220422_064537_827591_06832004 X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 08, 2022 at 09:40:09AM +0530, Anshuman Khandual wrote: > Possible page table entries (or pointers) on non-zero page table levels are > dependent on a single page size i.e PAGE_SIZE and size required for each > individual page table entry i.e 8 bytes. PTRS_PER_[PMD|PUD] as such are not > related to PTRS_PER_PTE in any manner, as being implied currently. So lets > just make this very explicit and compute these macros independently. OTOH, we have lots of other assumptions about pmd etc. being updated using the pte macros. Anyway, I'm fine with this. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F294FC433F5 for ; Fri, 22 Apr 2022 13:45:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1448023AbiDVNsd (ORCPT ); Fri, 22 Apr 2022 09:48:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352444AbiDVNsa (ORCPT ); Fri, 22 Apr 2022 09:48:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6970CBB8 for ; Fri, 22 Apr 2022 06:45:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1C4E3B82AC6 for ; Fri, 22 Apr 2022 13:45:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0072C385A4; Fri, 22 Apr 2022 13:45:33 +0000 (UTC) Date: Fri, 22 Apr 2022 14:45:30 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/mm: Compute PTRS_PER_[PMD|PUD] independently of PTRS_PER_PTE Message-ID: References: <20220408041009.1259701-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408041009.1259701-1-anshuman.khandual@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 08, 2022 at 09:40:09AM +0530, Anshuman Khandual wrote: > Possible page table entries (or pointers) on non-zero page table levels are > dependent on a single page size i.e PAGE_SIZE and size required for each > individual page table entry i.e 8 bytes. PTRS_PER_[PMD|PUD] as such are not > related to PTRS_PER_PTE in any manner, as being implied currently. So lets > just make this very explicit and compute these macros independently. OTOH, we have lots of other assumptions about pmd etc. being updated using the pte macros. Anyway, I'm fine with this. -- Catalin