From: Matthias Kaehlcke <mka@chromium.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Sandeep Maheswaram <quic_c_sanm@quicinc.com>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Linux PM <linux-pm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:"
<linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com,
quic_kriskura@quicinc.com, quic_vpulyala@quicinc.com
Subject: Re: [PATCH v14 2/7] PM / wakeup: Add device_children_wakeup_capable()
Date: Fri, 22 Apr 2022 11:44:36 -0700 [thread overview]
Message-ID: <YmL3lMaR79wPMEfY@google.com> (raw)
In-Reply-To: <CAJZ5v0h2ZKPN6SERPnASPywZfeOWXWncJgNZ1WZa80+=M4DCiQ@mail.gmail.com>
On Fri, Apr 22, 2022 at 01:57:17PM +0200, Rafael J. Wysocki wrote:
> On Tue, Apr 19, 2022 at 9:11 PM Sandeep Maheswaram
> <quic_c_sanm@quicinc.com> wrote:
> >
> > From: Matthias Kaehlcke <mka@chromium.org>
> >
> > Add device_children_wakeup_capable() which checks whether the device itself
> > or one if its descendants is wakeup capable.
>
> device_wakeup_path() exists for a very similar purpose.
>
> Is it not usable for whatever you need the new function introduced here?
I wasn't aware of it's function, there are no doc comments and the
name isn't really self explanatory.
In a quick test device_wakeup_path() returned inconsistent values for the
root hub, sometimes true, others false when a wakeup capable USB device was
connected.
next prev parent reply other threads:[~2022-04-22 19:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 19:11 [PATCH v14 0/7] USB DWC3 host wake up support from system suspend Sandeep Maheswaram
2022-04-19 19:11 ` [PATCH v14 1/7] dt-bindings: usb: dwc3: Add wakeup-source property support Sandeep Maheswaram
2022-04-19 19:11 ` [PATCH v14 2/7] PM / wakeup: Add device_children_wakeup_capable() Sandeep Maheswaram
2022-04-22 11:57 ` Rafael J. Wysocki
2022-04-22 18:44 ` Matthias Kaehlcke [this message]
2022-04-25 13:03 ` Pavan Kondeti
2022-04-29 12:59 ` Pavan Kondeti
2022-04-29 19:19 ` Matthias Kaehlcke
2022-04-30 3:11 ` Pavan Kondeti
2022-05-03 0:57 ` Matthias Kaehlcke
2022-04-19 19:11 ` [PATCH v14 3/7] usb: dwc3: core: Host wake up support from system suspend Sandeep Maheswaram
2022-05-04 17:46 ` Matthias Kaehlcke
2022-05-05 3:26 ` Pavan Kondeti
2022-05-05 16:45 ` Matthias Kaehlcke
2022-05-06 3:01 ` Pavan Kondeti
2022-05-06 16:43 ` Matthias Kaehlcke
2022-04-19 19:11 ` [PATCH v14 4/7] usb: dwc3: qcom: Add helper functions to enable,disable wake irqs Sandeep Maheswaram
2022-04-19 19:11 ` [PATCH v14 5/7] usb: dwc3: qcom: Configure wakeup interrupts during suspend Sandeep Maheswaram
2022-04-19 19:11 ` [PATCH v14 6/7] usb: dwc3: qcom: Keep power domain on to retain controller status Sandeep Maheswaram
2022-04-19 19:11 ` [PATCH v14 7/7] arm64: dts: qcom: sc7280: Add wakeup-source property for USB node Sandeep Maheswaram
2022-04-19 20:40 ` [PATCH v14 0/7] USB DWC3 host wake up support from system suspend patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmL3lMaR79wPMEfY@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=pavel@ucw.cz \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_vpulyala@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.