All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Douglas Gilbert <dgilbert@interlog.com>,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-modules@vger.kernel.org,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Pankaj Malhotra <pankaj1.m@samsung.com>,
	Vincent Fu <vincent.fu@samsung.com>
Subject: Re: scsi_debug in fstests and blktests (Was: Re: Fwd: [bug report][bisected] modprob -r scsi-debug take more than 3mins during blktests srp/ tests)
Date: Sat, 23 Apr 2022 09:50:24 -0700	[thread overview]
Message-ID: <YmQuUM4A0dB3KgLt@infradead.org> (raw)
In-Reply-To: <YmLEeUhTImWKIshO@bombadil.infradead.org>

On Fri, Apr 22, 2022 at 08:06:33AM -0700, Luis Chamberlain wrote:
> It begs the question if the same wish should apply to fstests.

xfstests generally works fine except for a handful test that explicitly
want module removal but _notrun gracefully in that case.  Unlike
blktests which just explodes.

> If we want to *not* rely on module removal then the right thing to do I
> think would be to replace module removal on these debug modules
> (scsi_debug) with an API as null_blk has which uses configfs to *add* /
> *remove* devices.

scsi_debug has runtime writable module parameters that cover just
about everything.

  reply	other threads:[~2022-04-23 16:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-02  7:06 [bug report][bisected] modprob -r scsi-debug take more than 3mins during blktests srp/ tests Yi Zhang
2022-04-08  1:45 ` Yi Zhang
     [not found]   ` <fba69540-b623-9602-a0e2-00de3348dbd6@interlog.com>
     [not found]     ` <YlW7gY8nr9LnBEF+@bombadil.infradead.org>
     [not found]       ` <00ebace8-b513-53c0-f13b-d3320757695d@interlog.com>
2022-04-21 17:53         ` scsi_debug in fstests and blktests (Was: Re: Fwd: [bug report][bisected] modprob -r scsi-debug take more than 3mins during blktests srp/ tests) Luis Chamberlain
2022-04-22  5:56           ` Christoph Hellwig
2022-04-22 12:34             ` Theodore Ts'o
2022-04-22 15:08               ` Luis Chamberlain
2022-04-22 15:19               ` Christoph Hellwig
2022-04-22 15:06             ` Luis Chamberlain
2022-04-23 16:50               ` Christoph Hellwig [this message]
2022-04-26  6:27                 ` Chaitanya Kulkarni
2022-04-25 19:22               ` Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmQuUM4A0dB3KgLt@infradead.org \
    --to=hch@infradead.org \
    --cc=bvanassche@acm.org \
    --cc=dgilbert@interlog.com \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    --cc=mcgrof@kernel.org \
    --cc=pankaj1.m@samsung.com \
    --cc=vincent.fu@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.