From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CDD0C433F5 for ; Mon, 25 Apr 2022 10:36:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9767460DA0; Mon, 25 Apr 2022 10:36:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yg3KeHN5PLDS; Mon, 25 Apr 2022 10:36:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id D1DD860BF6; Mon, 25 Apr 2022 10:36:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 03545C0096; Mon, 25 Apr 2022 10:36:19 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5F47CC007F for ; Mon, 25 Apr 2022 10:36:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4164960AE2 for ; Mon, 25 Apr 2022 10:36:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Emwc6U9B3eey for ; Mon, 25 Apr 2022 10:36:10 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5231460B6C for ; Mon, 25 Apr 2022 10:36:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1225A60EC5; Mon, 25 Apr 2022 10:36:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BC36C385A7; Mon, 25 Apr 2022 10:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650882968; bh=wkyNxnKYvpuBo7kmCBxnLUwwRMn5XI30arFCVougD+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fJJ/Pe5gF0UyKVzOXciVE3aqwc6iWwdwdYr988a7lID1iQ8yjBxPZE6CYNvnKBVwI DyfBf6AzVmnP2OUwy1fiUJ59QMW6ySgHu6T5onoZe/2j7hzuMygTzuHrTooWQqCqZY U2zcNMEmgto2jAUNTCmWHt9P4niJptV5mitbJLd8= Date: Mon, 25 Apr 2022 12:36:05 +0200 From: Greg Kroah-Hartman To: Shile Zhang Subject: Re: [PATCH 5.10.y] drm/cirrus: fix a NULL vs IS_ERR() checks Message-ID: References: <20211228132556.108711-1-shile.zhang@linux.alibaba.com> <1cc25ebe-2c68-458b-15a2-fc4c80ba2054@linux.alibaba.com> <550e9439-adf6-3df8-41a0-9a7ee5447907@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <550e9439-adf6-3df8-41a0-9a7ee5447907@linux.alibaba.com> Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Wen Kang , stable@vger.kernel.org, Daniel Vetter X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Sun, Apr 24, 2022 at 11:27:17AM +0800, Shile Zhang wrote: > Hi David and Daniel, > > Sorry but could you please help to check this issue? > Due to the function 'drm_gem_shmem_vmap' could return ERROR pointers which > will cause the kernel crash due to 'cirrus_fb_blit_rect' only check the > pointer. > > Since the related code has been refactoring in mainline, so this issue only > happened in stable 5.10.y branch. > > @Greg > I think it is probably not realistic to backport the related refactoring > from mainline directly, so I just give this bugfix patch only for 5.10.y > branch. I'm sorry, but I do not have "this bugfix" in my queue anymore, considering it is so old. Please rebase and resubmit. thanks, greg k-h _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43D8AC433F5 for ; Mon, 25 Apr 2022 10:36:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 47D8D10E237; Mon, 25 Apr 2022 10:36:13 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E34210E237 for ; Mon, 25 Apr 2022 10:36:11 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1225A60EC5; Mon, 25 Apr 2022 10:36:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BC36C385A7; Mon, 25 Apr 2022 10:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650882968; bh=wkyNxnKYvpuBo7kmCBxnLUwwRMn5XI30arFCVougD+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fJJ/Pe5gF0UyKVzOXciVE3aqwc6iWwdwdYr988a7lID1iQ8yjBxPZE6CYNvnKBVwI DyfBf6AzVmnP2OUwy1fiUJ59QMW6ySgHu6T5onoZe/2j7hzuMygTzuHrTooWQqCqZY U2zcNMEmgto2jAUNTCmWHt9P4niJptV5mitbJLd8= Date: Mon, 25 Apr 2022 12:36:05 +0200 From: Greg Kroah-Hartman To: Shile Zhang Subject: Re: [PATCH 5.10.y] drm/cirrus: fix a NULL vs IS_ERR() checks Message-ID: References: <20211228132556.108711-1-shile.zhang@linux.alibaba.com> <1cc25ebe-2c68-458b-15a2-fc4c80ba2054@linux.alibaba.com> <550e9439-adf6-3df8-41a0-9a7ee5447907@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550e9439-adf6-3df8-41a0-9a7ee5447907@linux.alibaba.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Wen Kang , stable@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Apr 24, 2022 at 11:27:17AM +0800, Shile Zhang wrote: > Hi David and Daniel, > > Sorry but could you please help to check this issue? > Due to the function 'drm_gem_shmem_vmap' could return ERROR pointers which > will cause the kernel crash due to 'cirrus_fb_blit_rect' only check the > pointer. > > Since the related code has been refactoring in mainline, so this issue only > happened in stable 5.10.y branch. > > @Greg > I think it is probably not realistic to backport the related refactoring > from mainline directly, so I just give this bugfix patch only for 5.10.y > branch. I'm sorry, but I do not have "this bugfix" in my queue anymore, considering it is so old. Please rebase and resubmit. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2598AC433F5 for ; Mon, 25 Apr 2022 10:36:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238148AbiDYKjW (ORCPT ); Mon, 25 Apr 2022 06:39:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234919AbiDYKjQ (ORCPT ); Mon, 25 Apr 2022 06:39:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1095FB7C8; Mon, 25 Apr 2022 03:36:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3790B8128F; Mon, 25 Apr 2022 10:36:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BC36C385A7; Mon, 25 Apr 2022 10:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650882968; bh=wkyNxnKYvpuBo7kmCBxnLUwwRMn5XI30arFCVougD+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fJJ/Pe5gF0UyKVzOXciVE3aqwc6iWwdwdYr988a7lID1iQ8yjBxPZE6CYNvnKBVwI DyfBf6AzVmnP2OUwy1fiUJ59QMW6ySgHu6T5onoZe/2j7hzuMygTzuHrTooWQqCqZY U2zcNMEmgto2jAUNTCmWHt9P4niJptV5mitbJLd8= Date: Mon, 25 Apr 2022 12:36:05 +0200 From: Greg Kroah-Hartman To: Shile Zhang Cc: David Airlie , Daniel Vetter , Wen Kang , stable@vger.kernel.org, virtualization@lists.linux-foundation.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5.10.y] drm/cirrus: fix a NULL vs IS_ERR() checks Message-ID: References: <20211228132556.108711-1-shile.zhang@linux.alibaba.com> <1cc25ebe-2c68-458b-15a2-fc4c80ba2054@linux.alibaba.com> <550e9439-adf6-3df8-41a0-9a7ee5447907@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550e9439-adf6-3df8-41a0-9a7ee5447907@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 24, 2022 at 11:27:17AM +0800, Shile Zhang wrote: > Hi David and Daniel, > > Sorry but could you please help to check this issue? > Due to the function 'drm_gem_shmem_vmap' could return ERROR pointers which > will cause the kernel crash due to 'cirrus_fb_blit_rect' only check the > pointer. > > Since the related code has been refactoring in mainline, so this issue only > happened in stable 5.10.y branch. > > @Greg > I think it is probably not realistic to backport the related refactoring > from mainline directly, so I just give this bugfix patch only for 5.10.y > branch. I'm sorry, but I do not have "this bugfix" in my queue anymore, considering it is so old. Please rebase and resubmit. thanks, greg k-h