All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] sighold02: Fix muslc builds by removing __SIGRTMIN
Date: Mon, 25 Apr 2022 11:35:19 +0200	[thread overview]
Message-ID: <YmZrVzxghAnmxIud@rei> (raw)
In-Reply-To: <20220425092118.21619-1-rpalethorpe@suse.com>

Hi!
> The minimum real-time signal is always 32 according to
> signal(7). Meanwhile __SIGRTMIN is not defined in all lib C
> implementations.
> 
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> ---
>  testcases/kernel/syscalls/sighold/sighold02.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/sighold/sighold02.c b/testcases/kernel/syscalls/sighold/sighold02.c
> index daa86192e..1cfb7688b 100644
> --- a/testcases/kernel/syscalls/sighold/sighold02.c
> +++ b/testcases/kernel/syscalls/sighold/sighold02.c
> @@ -33,7 +33,7 @@ static int sigs_map[NUMSIGS];
>  
>  static int skip_sig(int sig)
>  {
> -	if (sig >= __SIGRTMIN && sig < SIGRTMIN)
> +	if (sig >= 32 && sig < SIGRTMIN)
>  		return 1;

Looks like __SIGRTMIN is defined to 32 for all architectures glibc
supports, so this should be pretty much safe.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-04-25  9:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25  9:21 [LTP] [PATCH] sighold02: Fix muslc builds by removing __SIGRTMIN Richard Palethorpe via ltp
2022-04-25  9:35 ` Cyril Hrubis [this message]
2022-04-25 11:08   ` Petr Vorel
2022-04-25 11:09     ` Petr Vorel
2022-04-25 11:23       ` Cyril Hrubis
2022-04-27  7:57         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmZrVzxghAnmxIud@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.