From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Manali Shukla <manali.shukla@amd.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests RESEND PATCH v3 0/8] Move npt test cases and NPT code improvements
Date: Mon, 25 Apr 2022 14:48:08 +0000 [thread overview]
Message-ID: <Yma0qPzbYU+pSZhd@google.com> (raw)
In-Reply-To: <19e902c3-b3cd-a9cc-be0f-d709b2a52c77@redhat.com>
On Mon, Apr 25, 2022, Paolo Bonzini wrote:
> On 4/25/22 13:44, Manali Shukla wrote:
> > If __setup_vm() is changed to setup_vm(), KUT will build tests with
> > PT_USER_MASK set on all PTEs. It is a better idea to move nNPT tests
> > to their own file so that tests don't need to fiddle with page tables midway.
>
> Sorry, I have already asked this but I don't understand: why is it
> problematic to have PT_USER_MASK set on all PTEs, since you have a patch (3)
> to "allow nSVM tests to run with PT_USER_MASK enabled"?
svm_npt_rsvd_bits_test() intentionally sets hCR4.SMEP=1 to verify that KVM doesn't
consume the host's value for the guest. Having USER set on PTEs causes the test
to hit SMEP violations.
prev parent reply other threads:[~2022-04-25 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 11:44 [kvm-unit-tests RESEND PATCH v3 0/8] Move npt test cases and NPT code improvements Manali Shukla
2022-04-25 11:44 ` [kvm-unit-tests RESEND PATCH v3 1/8] x86: nSVM: Move common functionality of the main() to helper run_svm_tests Manali Shukla
2022-04-25 11:44 ` [kvm-unit-tests RESEND PATCH v3 2/8] x86: nSVM: Move all nNPT test cases from svm_tests.c to a separate file Manali Shukla
2022-04-25 11:44 ` [kvm-unit-tests RESEND PATCH v3 3/8] x86: nSVM: Allow nSVM tests run with PT_USER_MASK enabled Manali Shukla
2022-04-25 11:44 ` [kvm-unit-tests RESEND PATCH v3 4/8] x86: Improve set_mmu_range() to implement npt Manali Shukla
2022-04-25 11:44 ` [kvm-unit-tests RESEND PATCH v3 5/8] x86: nSVM: Build up the nested page table dynamically Manali Shukla
2022-04-25 11:44 ` [kvm-unit-tests RESEND PATCH v3 6/8] x86: nSVM: Correct indentation for svm.c Manali Shukla
2022-04-25 11:44 ` [kvm-unit-tests RESEND PATCH v3 7/8] x86: nSVM: Correct indentation for svm_tests.c part-1 Manali Shukla
2022-04-25 11:44 ` [kvm-unit-tests RESEND PATCH v3 8/8] x86: nSVM: Correct indentation for svm_tests.c part-2 Manali Shukla
2022-04-25 13:29 ` Paolo Bonzini
2022-04-27 3:36 ` Shukla, Manali
2022-04-25 13:31 ` [kvm-unit-tests RESEND PATCH v3 0/8] Move npt test cases and NPT code improvements Paolo Bonzini
2022-04-25 14:48 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yma0qPzbYU+pSZhd@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=manali.shukla@amd.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.