All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, sudeep.holla@arm.com,
	dietmar.eggemann@arm.com, vincent.guittot@linaro.org,
	rafael@kernel.org, rostedt@goodmis.org, mingo@redhat.com
Subject: Re: [PATCH v2] arch_topology: Trace the update thermal pressure
Date: Mon, 25 Apr 2022 16:12:50 +0200	[thread overview]
Message-ID: <YmasYv5xHH7EbXXn@kroah.com> (raw)
In-Reply-To: <20220425135317.5880-1-lukasz.luba@arm.com>

On Mon, Apr 25, 2022 at 02:53:17PM +0100, Lukasz Luba wrote:
> Add trace event to capture the moment of the call for updating the thermal
> pressure value. It's helpful to investigate how often those events occurs
> in a system dealing with throttling. This trace event is needed since the
> old 'cdev_update' might not be used by some drivers. Also, the new trace
> event shows capacity value, not a cooling state.

Wait, why are thermal events not going through the thermal system so
that thermal_cdev_update() would catch them?  Don't work around broken
systems, force them to use the correct apis.

thanks,

greg k-h

  reply	other threads:[~2022-04-25 14:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 13:53 [PATCH v2] arch_topology: Trace the update thermal pressure Lukasz Luba
2022-04-25 14:12 ` Greg KH [this message]
2022-04-26  7:26   ` Lukasz Luba
2022-04-26  8:12     ` Greg KH
2022-04-26  9:00       ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmasYv5xHH7EbXXn@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=mingo@redhat.com \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.