From: Rob Herring <robh@kernel.org>
To: David Heidelberg <david@ixit.cz>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450
Date: Mon, 25 Apr 2022 19:53:49 -0500 [thread overview]
Message-ID: <YmdCnWRu6AgBlsEH@robh.at.kernel.org> (raw)
In-Reply-To: <33da014b-bfb0-a39f-aba7-f469fcb5cfbb@ixit.cz>
On Mon, Apr 25, 2022 at 04:05:57PM +0200, David Heidelberg wrote:
> On 25/04/2022 15:51, Krzysztof Kozlowski wrote:
> > On 25/04/2022 15:47, David Heidelberg wrote:
> > > Adds forgotten compatible and update SPDX header.
> > You need to explain what is this "forgotten compatible". It's to vague.
> Forgotten by someone who implemented it in driver. Hope that clarify it for
> you and possibly other readers. Btw. qcom,*sm8450* compatibles are widely
> used and fact that `make dtbs_check` noticed it missing here isn't
> suprising..
> >
> > The SPDX update lacks answer to "why". There is no reason to do it, so
> > please explain why it is needed.
>
> Please read https://spdx.org/licenses/GPL-2.0.html (red colored text).
>
> I personally encountered situation, where usage GPL license without specific
> `-only` or `-or-later` caused unnecessary confusion and uncertainty.
I don't mind changing these, but please do a tree wide change for all
bindings, not an 'while I'm here also change X' change.
Rob
prev parent reply other threads:[~2022-04-26 0:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 13:47 [PATCH v3 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 David Heidelberg
2022-04-25 13:47 ` [PATCH v3 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example David Heidelberg
2022-04-25 13:51 ` [PATCH v3 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 Krzysztof Kozlowski
2022-04-25 14:05 ` David Heidelberg
2022-04-25 14:11 ` Krzysztof Kozlowski
2022-04-26 0:53 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmdCnWRu6AgBlsEH@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.