From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Liu Xinpeng <liuxp11@chinatelecom.cn>
Cc: wim@linux-watchdog.org, linux@roeck-us.net,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition
Date: Tue, 26 Apr 2022 14:13:36 +0800 [thread overview]
Message-ID: <YmeNkC8B9glPt2S8@google.com> (raw)
In-Reply-To: <1650944120-30954-5-git-send-email-liuxp11@chinatelecom.cn>
On Tue, Apr 26, 2022 at 11:35:20AM +0800, Liu Xinpeng wrote:
> @@ -596,7 +596,6 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
> /*
> * Suspend-to-idle requires this, because it stops the ticks and timekeeping, so
> * the watchdog cannot be pinged while in that state. In ACPI sleep states the
> @@ -637,20 +636,15 @@ static int iTCO_wdt_resume_noirq(struct device *dev)
> }
>
> static const struct dev_pm_ops iTCO_wdt_pm = {
> - .suspend_noirq = iTCO_wdt_suspend_noirq,
> - .resume_noirq = iTCO_wdt_resume_noirq,
> + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(iTCO_wdt_suspend_noirq,
> + iTCO_wdt_resume_noirq)
Thus, iTCO_wdt_suspend_noirq and iTCO_wdt_resume_noirq are possible unused.
Put __maybe_unused attribute to them.
prev parent reply other threads:[~2022-04-26 6:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 3:35 [PATCH v3 0/4] Some Impovements about watchdog Liu Xinpeng
2022-04-26 3:35 ` [PATCH v3 1/4] watchdog: wdat_wdg: Using the existed function to check parameter timeout Liu Xinpeng
2022-04-26 6:10 ` Tzung-Bi Shih
2022-04-26 8:12 ` Guenter Roeck
2022-04-26 3:35 ` [PATCH v3 2/4] watchdog: wdat_wdg: Stop watchdog when rebooting the system Liu Xinpeng
2022-04-26 3:35 ` [PATCH v3 3/4] watchdog: wdat_wdg: Stop watchdog when uninstalling module Liu Xinpeng
2022-04-26 3:35 ` [PATCH v3 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition Liu Xinpeng
2022-04-26 6:13 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmeNkC8B9glPt2S8@google.com \
--to=tzungbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=liuxp11@chinatelecom.cn \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.