From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02A23C433FE for ; Tue, 26 Apr 2022 06:42:54 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-551-a3nInYKtPjGZEse-KoD1qg-1; Tue, 26 Apr 2022 02:42:50 -0400 X-MC-Unique: a3nInYKtPjGZEse-KoD1qg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 802FA1C0BF09; Tue, 26 Apr 2022 06:42:48 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F314416162; Tue, 26 Apr 2022 06:42:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 24B911947BBE; Tue, 26 Apr 2022 06:42:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BB40B19451F2 for ; Tue, 26 Apr 2022 06:42:44 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A724641617F; Tue, 26 Apr 2022 06:42:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A342B40D1CF for ; Tue, 26 Apr 2022 06:42:44 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8B05B80346E for ; Tue, 26 Apr 2022 06:42:44 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-58-lrnvoSt9Nmqs-p8ShA3gkA-1; Tue, 26 Apr 2022 02:42:40 -0400 X-MC-Unique: lrnvoSt9Nmqs-p8ShA3gkA-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 71BF661450; Tue, 26 Apr 2022 06:42:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDE64C385AE; Tue, 26 Apr 2022 06:42:38 +0000 (UTC) Date: Tue, 26 Apr 2022 08:42:36 +0200 From: Greg Kroah-Hartman To: Mikulas Patocka Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Subject: Re: [dm-devel] [PATCH v5.10] dm: fix mempool NULL pointer race when completing IO X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mike Snitzer , dm-devel@redhat.com, stable@vger.kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Apr 21, 2022 at 02:08:30PM -0400, Mikulas Patocka wrote: > Hi Not really needed in a changelog text :) > This is backport of patches d208b89401e0 ("dm: fix mempool NULL pointer > race when completing IO") and 9f6dc6337610 ("dm: interlock pending dm_io > and dm_wait_for_bios_completion") for the kernel 5.10. Can you just make these 2 different patches? > > The bugs fixed by these patches can cause random crashing when reloading > dm table, so it is eligible for stable backport. > > This patch is different from the upstream patches because the code > diverged significantly. > This change is _VERY_ different. I would need acks from the maintainers of this code before I could accept this, along with a much more detailed description of why the original commits will not work here as well. Same for the other backports. thanks, greg k-h -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E9C2C433EF for ; Tue, 26 Apr 2022 06:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245544AbiDZGps (ORCPT ); Tue, 26 Apr 2022 02:45:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245613AbiDZGpq (ORCPT ); Tue, 26 Apr 2022 02:45:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3751FF1EC0 for ; Mon, 25 Apr 2022 23:42:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C7E7B6147B for ; Tue, 26 Apr 2022 06:42:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDE64C385AE; Tue, 26 Apr 2022 06:42:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650955359; bh=n8HSVt9hXiYKFxnlhdXE6sVXrPOQE2ipuCqNqz3/s3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SHvLJpEXj7oxwBHmqOesXz/SGAo0OkVbdk/fZM1TbTnKQNzq+GJM9EZ0q+nedxNTk Tn3RyvFli2XfedM19w0GB5LIK1K7iequnTpOmZZ0lJ0JV1IwZBr1p+yzxFxIcOe408 d+pdi8IlpsCWYl0qudEwX+zWwAV5Fd+fSuQkO2OA= Date: Tue, 26 Apr 2022 08:42:36 +0200 From: Greg Kroah-Hartman To: Mikulas Patocka Cc: stable@vger.kernel.org, Mike Snitzer , dm-devel@redhat.com Subject: Re: [PATCH v5.10] dm: fix mempool NULL pointer race when completing IO Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Apr 21, 2022 at 02:08:30PM -0400, Mikulas Patocka wrote: > Hi Not really needed in a changelog text :) > This is backport of patches d208b89401e0 ("dm: fix mempool NULL pointer > race when completing IO") and 9f6dc6337610 ("dm: interlock pending dm_io > and dm_wait_for_bios_completion") for the kernel 5.10. Can you just make these 2 different patches? > > The bugs fixed by these patches can cause random crashing when reloading > dm table, so it is eligible for stable backport. > > This patch is different from the upstream patches because the code > diverged significantly. > This change is _VERY_ different. I would need acks from the maintainers of this code before I could accept this, along with a much more detailed description of why the original commits will not work here as well. Same for the other backports. thanks, greg k-h