From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F03FC433EF for ; Tue, 26 Apr 2022 08:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344219AbiDZIIn (ORCPT ); Tue, 26 Apr 2022 04:08:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232960AbiDZIIf (ORCPT ); Tue, 26 Apr 2022 04:08:35 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 94C29DF3B; Tue, 26 Apr 2022 01:05:26 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A378580C0; Tue, 26 Apr 2022 08:02:23 +0000 (UTC) Date: Tue, 26 Apr 2022 11:05:23 +0300 From: Tony Lindgren To: Ren Yu Cc: aaro.koskinen@iki.fi, linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, liqiong@nfschina.com, yuzhe@nfschina.com, Arnd Bergmann Subject: Re: [PATCH] plat-omap: check return value of ioremap() Message-ID: References: <20220425110845.415439-1-renyu@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220425110845.415439-1-renyu@nfschina.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, * Ren Yu [220425 11:08]: > When ioremap() failed,return err This file is no longer being used and getting removed in Linux next. See commit 7058e68c2fed ("ARM: omap: remove debug-leds driver"). Thanks, Tony > Signed-off-by: Ren Yu > --- > arch/arm/plat-omap/debug-leds.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/plat-omap/debug-leds.c b/arch/arm/plat-omap/debug-leds.c > index 2b698d074874..bf5034e10f6e 100644 > --- a/arch/arm/plat-omap/debug-leds.c > +++ b/arch/arm/plat-omap/debug-leds.c > @@ -109,6 +109,9 @@ static int fpga_probe(struct platform_device *pdev) > return -ENODEV; > > fpga = ioremap(iomem->start, resource_size(iomem)); > + if (!fpga) > + return -ENOMEM; > + > writew_relaxed(0xff, &fpga->leds); > > for (i = 0; i < ARRAY_SIZE(dbg_leds); i++) { > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69A95C433EF for ; Tue, 26 Apr 2022 08:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8yTJkmy+MsCJCPJRQmgSshGhc9ghV6fFC2JkzgS1zLk=; b=LmSir5fom8mB44 KZyS+HXKlvE1TFg0z8OBZ0NmfOtebob6aae0tfVAoqJdq7ikG3evCILuZFRm+Xc09A5j5DGfmjp1S LiDTVaEaoGe0O4JSUELyueyLqCpooItlZ/swWUM9ucOyxOVcXjil8buR0iBrJpgQi+xrk4J+iwXAy XxVQYYDfbqNKzTiXj5IteVUnkJDHwG8P3BRxXQvZAAikga2bJR/Wb8O4WY1V+Q57UvyY7YXWQB5yD MfIE5J9FG5c7p/cuvvYrwDhnGqhaky8TtGE4/B0Q1k0JyR8zaWf2PuwpLnw7yjNeF0P8+2cPeEYVC eyylDLP9y55HJey+BIkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njGCT-00DBem-IE; Tue, 26 Apr 2022 08:05:33 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njGCN-00DBcc-Lh for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 08:05:31 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A378580C0; Tue, 26 Apr 2022 08:02:23 +0000 (UTC) Date: Tue, 26 Apr 2022 11:05:23 +0300 From: Tony Lindgren To: Ren Yu Cc: aaro.koskinen@iki.fi, linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, liqiong@nfschina.com, yuzhe@nfschina.com, Arnd Bergmann Subject: Re: [PATCH] plat-omap: check return value of ioremap() Message-ID: References: <20220425110845.415439-1-renyu@nfschina.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220425110845.415439-1-renyu@nfschina.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_010527_807344_0BA48B39 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Ren Yu [220425 11:08]: > When ioremap() failed,return err This file is no longer being used and getting removed in Linux next. See commit 7058e68c2fed ("ARM: omap: remove debug-leds driver"). Thanks, Tony > Signed-off-by: Ren Yu > --- > arch/arm/plat-omap/debug-leds.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/plat-omap/debug-leds.c b/arch/arm/plat-omap/debug-leds.c > index 2b698d074874..bf5034e10f6e 100644 > --- a/arch/arm/plat-omap/debug-leds.c > +++ b/arch/arm/plat-omap/debug-leds.c > @@ -109,6 +109,9 @@ static int fpga_probe(struct platform_device *pdev) > return -ENODEV; > > fpga = ioremap(iomem->start, resource_size(iomem)); > + if (!fpga) > + return -ENOMEM; > + > writew_relaxed(0xff, &fpga->leds); > > for (i = 0; i < ARRAY_SIZE(dbg_leds); i++) { > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel