From: Lee Jones <lee.jones@linaro.org>
To: cgel.zte@gmail.com
Cc: gremlin@gremlin.it, gregkh@linuxfoundation.org,
mad_soft@inbox.ru, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, Lv Ruyi <lv.ruyi@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] mfd: fix error check return value of platform_get_irq()
Date: Tue, 26 Apr 2022 15:12:13 +0100 [thread overview]
Message-ID: <Ymf9vfkhXVbqF5pi@google.com> (raw)
In-Reply-To: <20220412085305.2533030-1-lv.ruyi@zte.com.cn>
On Tue, 12 Apr 2022, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> platform_get_irq() return negative value on failure, so null check of
> irq is incorrect. Fix it by comparing whether it is less than zero.
>
> Fixes: dcc21cc09e3c ("mfd: Add driver for Atmel Microcontroller on iPaq h3xxx")
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> drivers/mfd/ipaq-micro.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I fixed the subject line for you and applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2022-04-26 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 8:53 [PATCH] mfd: fix error check return value of platform_get_irq() cgel.zte
2022-04-12 13:46 ` Linus Walleij
2022-04-26 14:12 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymf9vfkhXVbqF5pi@google.com \
--to=lee.jones@linaro.org \
--cc=cgel.zte@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gremlin@gremlin.it \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=mad_soft@inbox.ru \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.