All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daehwan Jung <dh10.jung@samsung.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	"open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Howard Yen <howardyen@google.com>,
	Jack Pham <jackp@codeaurora.org>, Puma Hsu <pumahsu@google.com>,
	"J . Avila" <elavila@google.com>,
	sc.suh@samsung.com,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Subject: Re: [PATCH v4 5/5] usb: host: add xhci-exynos driver
Date: Tue, 26 Apr 2022 12:21:40 +0200	[thread overview]
Message-ID: <YmfHtFFIJp6z7ysK@kroah.com> (raw)
In-Reply-To: <1650964728-175347-6-git-send-email-dh10.jung@samsung.com>

On Tue, Apr 26, 2022 at 06:18:48PM +0900, Daehwan Jung wrote:
> +int xhci_check_trb_in_td_math(struct xhci_hcd *xhci);
> +void xhci_segment_free(struct xhci_hcd *xhci, struct xhci_segment *seg);
> +void xhci_link_segments(struct xhci_segment *prev,
> +		struct xhci_segment *next,
> +		enum xhci_ring_type type, bool chain_links);
> +void xhci_initialize_ring_info(struct xhci_ring *ring,
> +					unsigned int cycle_state);
> +void xhci_remove_stream_mapping(struct xhci_ring *ring);

Why does your single driver have global functions?  That should not be
needed, right?

And these are odd for a driver's namespace...

thanks,

greg k-h

  parent reply	other threads:[~2022-04-26 10:35 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220426092019epcas2p2ef5dfde273edaaadc2ff74414f1b2c7a@epcas2p2.samsung.com>
2022-04-26  9:18 ` [PATCH v4 0/5] add xhci-exynos driver Daehwan Jung
2022-04-26  9:18   ` [PATCH v4 1/5] usb: host: export symbols for xhci-exynos to use xhci hooks Daehwan Jung
2022-04-26  9:54     ` Greg Kroah-Hartman
2022-04-26 10:27       ` Jung Daehwan
2022-04-26 10:31         ` Greg Kroah-Hartman
2022-04-26 18:40           ` Greg Kroah-Hartman
2022-04-28  3:30             ` Jung Daehwan
2022-04-26 16:02     ` kernel test robot
2022-04-26  9:18   ` [PATCH v4 2/5] usb: host: add xhci hooks for xhci-exynos Daehwan Jung
2022-04-26 10:19     ` Greg Kroah-Hartman
2022-04-27  9:06       ` Jung Daehwan
2022-04-27  9:19         ` Greg Kroah-Hartman
2022-04-28  3:23           ` Jung Daehwan
2022-04-28  5:30             ` Greg Kroah-Hartman
2022-04-26  9:18   ` [PATCH v4 3/5] usb: host: xhci-plat: support override of hc driver Daehwan Jung
2022-04-26 10:20     ` Greg Kroah-Hartman
2022-04-27  9:07       ` Jung Daehwan
2022-04-26  9:18   ` [PATCH v4 4/5] usb: host: add some to xhci overrides for xhci-exynos Daehwan Jung
2022-04-26 10:23     ` Greg Kroah-Hartman
2022-04-27  9:19       ` Jung Daehwan
2022-04-27  9:37         ` Greg Kroah-Hartman
2022-04-26  9:18   ` [PATCH v4 5/5] usb: host: add xhci-exynos driver Daehwan Jung
2022-04-26 10:20     ` Greg Kroah-Hartman
2022-04-28  3:26       ` Jung Daehwan
2022-04-26 10:21     ` Greg Kroah-Hartman [this message]
2022-04-27  9:24       ` Jung Daehwan
2022-04-27  9:37         ` Greg Kroah-Hartman
2022-04-26 12:59     ` Krzysztof Kozlowski
2022-04-28  1:29       ` Jung Daehwan
2022-04-28  5:19         ` Krzysztof Kozlowski
2022-04-28  6:36           ` Jung Daehwan
2022-04-28  6:45             ` Greg Kroah-Hartman
2022-04-28  7:45               ` Jung Daehwan
2022-04-28  7:31             ` Krzysztof Kozlowski
2022-04-28  7:53               ` Jung Daehwan
2022-04-28  8:26                 ` Krzysztof Kozlowski
2022-04-26 17:55     ` kernel test robot
2022-04-27 16:25     ` Mathias Nyman
2022-04-28  3:03       ` Jung Daehwan
2022-04-28 12:28         ` Mathias Nyman
2022-05-03  8:41           ` Jung Daehwan
2022-04-28  5:15       ` Jung Daehwan
2022-04-26 10:19   ` [PATCH v4 0/5] " Greg Kroah-Hartman
2022-04-26 12:46   ` Krzysztof Kozlowski
2022-04-27  9:49     ` Jung Daehwan
2022-04-27 18:24       ` Krzysztof Kozlowski
2022-04-28  3:19         ` Jung Daehwan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmfHtFFIJp6z7ysK@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dh10.jung@samsung.com \
    --cc=elavila@google.com \
    --cc=howardyen@google.com \
    --cc=jackp@codeaurora.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=pumahsu@google.com \
    --cc=sc.suh@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.